Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5195: Fix RestrictedApi Errors #5348

Merged
merged 31 commits into from
Apr 2, 2024
Merged

Fix #5195: Fix RestrictedApi Errors #5348

merged 31 commits into from
Apr 2, 2024

Conversation

XichengSpencer
Copy link
Collaborator

Explanation

Fixes #5195 In the Android/Lint errors, all I can see are just NewApi Errors, which related methods are only available on API 26 and our current min API is 19.
Correct me if I am wrong, as discussed with Ben in a meeting, most errors test-related file can be fixed by adding require api annotation, and for all the changed files I think they are test related so I added annotation. I did some investigation java.util.Time replacement method and it requires to install third-party dependency, which I think adds too much complexity so I proceed with the annotation way. And for the color matcher one, I cannot find the replacement method.

Essential Checklist

  • [z] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Screenshot 2024-02-21 092439

XichengSpencer and others added 27 commits July 4, 2023 01:01
@XichengSpencer
Resolve the test build error
3936364
@XichengSpencer
Change 1 concatenate string to 3 seperate text view
ed714a6
@XichengSpencer
format code
f1c1bac
@XichengSpencer
Merge branch 'oppia:develop' into oppia#3843
31b6f53
@XichengSpencer
Change the corresponding test.
24050dc
@adhiamboperes
Merge branch 'develop' into oppia#3843
3406c78
@XichengSpencer
Merge remote-tracking branch 'origin/oppia#3843' into oppia#3843
b1bfe10
@XichengSpencer
Remove TODO
9c56e24
@XichengSpencer
Merge branch 'develop' into oppia#3843
8d9cf96
@XichengSpencer
remove testAddProfileActivity_inputPin_configChange_downloadAccessSwi…
6fe9746 
…tchIsOn() as discussed

, fix enable download access logic
,improve testAddProfileActivity_configChange_inputShortPin_create_pinLengthError() but still flaky
@XichengSpencer
Merge branch 'develop' of https://github.com/oppia/oppia-android into o…
1cbe96d 
…ppia#3843
@adhiamboperes
Merge branch 'develop' into oppia#3843
582f69d
@XichengSpencer
Add comment to explain the negating logic
40c44df
@XichengSpencer
Merge remote-tracking branch 'origin/oppia#3843' into oppia#3843
6824346
@adhiamboperes
Merge branch 'develop' into oppia#3843
ebe5a28
@XichengSpencer
Add new HtmlParser create method that use less variables
b4b5f10
@XichengSpencer
Merge branch 'develop' of https://github.com/oppia/oppia-android into o…
4802202 
…ppia#3843
@XichengSpencer
Merge remote-tracking branch 'origin/oppia#3843' into oppia#3843
e40a900
@XichengSpencer
Merge branch 'oppia:develop' into oppia#3843
c362a55
@XichengSpencer
Remove customOppiaTagActionListener as input arg in HtmlParser.kt cre…
015b502 
…ate function that served for MathExpressionParserViewModel.kt
@XichengSpencer
Merge branch 'develop' of https://github.com/oppia/oppia-android into o…
698a0d1 
…ppia#3843
@XichengSpencer
Merge remote-tracking branch 'origin/oppia#3843' into oppia#3843
783432a
@XichengSpencer
Remove TODO list and updated unnamed variable in both create function
74b599c
@XichengSpencer
Fix all unnamed variables
2fc2da8
@XichengSpencer
Merge branch 'develop' of https://github.com/oppia/oppia-android into o…
a489412 
…ppia#3843
@XichengSpencer
Add annotation for methods not compatible with <API 26
0c1b62a 
There is no good replacement method for them in lower API level
@XichengSpencer
Merge branch 'develop' of https://github.com/oppia/oppia-android into o…
22040e2 
…ppia#3843
@XichengSpencer XichengSpencer requested review from a team as code owners February 23, 2024 23:54
@oppiabot OppiaBot
Copy link

oppiabot bot commented Mar 4, 2024

Hi @XichengSpencer, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 4, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 4, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Mar 11, 2024

Hi @XichengSpencer, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 11, 2024
adhiamboperes
adhiamboperes requested changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XichengSpencer! Please revert the unneeded changes an re-assign.

testing/src/main/java/org/oppia/android/testing/junit/OppiaParameterizedTestRunner.kt Outdated Show resolved Hide resolved
testing/src/main/java/org/oppia/android/testing/junit/OppiaParameterizedTestRunner.kt Outdated Show resolved Hide resolved
testing/src/main/java/org/oppia/android/testing/junit/OppiaParameterizedTestRunner.kt Outdated Show resolved Hide resolved
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 15, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Mar 22, 2024

Hi @XichengSpencer, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 22, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 26, 2024
@adhiamboperes
Copy link
Collaborator

@XichengSpencer, please reassign if this is ready for a review.

adhiamboperes
adhiamboperes approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XichengSpencer! This LGTM.

@adhiamboperes adhiamboperes merged commit f0e9ac9 into oppia:develop Apr 2, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhiamboperes adhiamboperes adhiamboperes approved these changes

Assignees

@adhiamboperes adhiamboperes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InvalidPackage + NewApi + FragmentLiveDataObserve + RestrictedApi
2 participants
@XichengSpencer @adhiamboperes