Fix #2587: testHomeActivity_allTopicsCompleted_displaysAllTopicCards() test not working

[deonwaju]

Explanation

Fix for #2587: split test method into 4 versions, [mobilePortrait, mobileLandscape, tabletPortrait, tabletLandscape]

A. Mobile potrait test

B. Mobile Lanscape

C. Tablet Portrait

D. Tablet Landscape test.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

[deonwaju]

PTAL @adhiamboperes

[adhiamboperes]

Thanks @deonwaju!

In addition to my inline comments, can you please share a screenshot that shows you ran these tests on an emulator/device and they passed? The issues describes the tests failing in tablet so we need proof that they now pass in tablets.

One more thing, was the issue reproducible before you wrote the fix? I find it strange that the original test had no prior configurations that limited it to running on robolectric, or ignoring it yet we had no reported failures(It's great that this PR increases the test coverage, but I'd like to check).

[deonwaju]

Thanks @deonwaju!

In addition to my inline comments, can you please share a screenshot that shows you ran these tests on an emulator/device and they passed? The issues describes the tests failing in tablet so we need proof that they now pass in tablets.

One more thing, was the issue reproducible before you wrote the fix? I find it strange that the original test had no prior configurations that limited it to running on robolectric, or ignoring it yet we had no reported failures(It's great that this PR increases the test coverage, but I'd like to check).

Ok got it, and yes the issue was reproducible, I took your advice to test on a larger tablet screen size, so used a 10" pixel C tablet, and I was able to reproduce the issue. Turns out that the test passes only when the tablet is in portrait mode, in landscape mode it fails. That was the issue

[deonwaju]

@adhiamboperes
Please find attached the screenshots for each of the tests.

A. Mobile portrait test

B. Mobile landscape test

C. Tablet portrait test

D. Tablet landscape test

[adhiamboperes]

@deonwaju, the tests look good. Please complete the test name suggestions and resubmit for approval.

[deonwaju]

PTAL @adhiamboperes

[oppiabot]

Unassigning @deonwaju since a re-review was requested. @deonwaju, please make sure you have addressed all review comments. Thanks!

[adhiamboperes]

Thanks @deonwaju! This LGTM.