Fix Part of #4938: Introduce Onboarding UI V2 2 of 3 #5327

adhiamboperes · 2024-01-31T20:36:35Z

Explanation

Fix Part of #4938: Intoduce the UI for the revised onboarding flow.

Learner-specific onboarding flow triggered upon a user opening the app for the first time.
When a user selects "learner" in the new onboarding flow, they will be directed to the "new learner" onboarding flow.
When a user selects "parent/teacher" in the new onboarding flow, they are directed to the profile selection screen showing the default-created admin.
Selection functionality for the user's app & audio languages.
Darkmode compliance
Tablet device responsiveness
Landscape orientation responsiveness
Re-used classes and resources where possible
Enforced resource and id naming patterns.

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Mobile


Light Mode	Dark Mode	Landscape

Tablet


Portrait	Landscape

…kgroundView Since many new designs include this custom shape, we can now reuse this view by passing in the desired background color.

… into new-onboarding-ui # Conflicts: # app/src/main/res/values/dimens.xml

adhiamboperes

First self-review pass.

app/src/main/java/org/oppia/android/app/onboarding/OnboardingFragmentPresenter.kt

app/src/main/AndroidManifest.xml

...rc/main/java/org/oppia/android/app/onboarding/onboardingv2/AudioLanguageFragmentPresenter.kt

app/src/main/res/values/strings.xml

app/src/sharedTest/java/org/oppia/android/app/onboarding/OnboardingFragmentTest.kt

scripts/assets/test_file_exemptions.textproto

scripts/assets/kdoc_validity_exemptions.textproto

adhiamboperes

Second self-review pass.

app/src/main/res/drawable/learner_otter.png

app/src/main/res/drawable/onboarding_back_button_white_background.xml

app/src/main/res/drawable/parent_teacher_otter.png

...rc/main/java/org/oppia/android/app/onboarding/onboardingv2/AudioLanguageFragmentPresenter.kt

app/src/main/res/layout/create_profile_fragment.xml

…to new-onboarding-ui

…oarding-ui

audio and new profile

oppiabot · 2024-03-05T14:38:46Z

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

adhiamboperes

Another self-review pass. Some refactors and failing test fixes needed.

...aredTest/java/org/oppia/android/app/onboarding/onboardingv2/NewLearnerProfileActivityTest.kt

...Test/java/org/oppia/android/app/onboarding/onboardingv2/OnboardingProfileTypeActivityTest.kt

...ava/org/oppia/android/app/onboarding/onboardingv2/OnboardingLearnerIntroFragmentPresenter.kt

...Test/java/org/oppia/android/app/onboarding/onboardingv2/OnboardingProfileTypeFragmentTest.kt

adhiamboperes · 2024-03-13T22:51:24Z

app/src/sharedTest/java/org/oppia/android/app/options/AudioLanguageFragmentTest.kt

+    forceEnableOnboardingFlowV2()
+    launchActivityWithLanguage(ENGLISH_AUDIO_LANGUAGE).use {
+      testCoroutineDispatchers.runCurrent()
+      onView(withId(R.id.audio_language_dropdown_background)).check(


Update to assert actual language. Ditto other tests

app/src/sharedTest/java/org/oppia/android/app/options/AudioLanguageFragmentTest.kt

adhiamboperes · 2024-03-13T22:52:51Z

...aredTest/java/org/oppia/android/app/onboarding/onboardingv2/NewLearnerProfileFragmentTest.kt

+      onView(withId(R.id.onboarding_navigation_continue))
+        .perform(click())
+      testCoroutineDispatchers.runCurrent()
+      intended(hasComponent(OnboardingLearnerIntroActivity::class.java.name))


Check for nichname in intent

adhiamboperes · 2024-03-13T22:54:07Z

app/src/sharedTest/java/org/oppia/android/app/options/AudioLanguageFragmentTest.kt

+      intended(hasComponent(HomeActivity::class.java.name))
+    }
+  }
+


Add checks for the rest of the views' visibility

…pdown.

…to new-onboarding-ui

…oarding-ui

oppiabot · 2024-03-26T00:43:58Z

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

adhiamboperes added 18 commits October 30, 2023 16:51

Add platform parameter for gating the new onboarding flow

ec0eded

Refactor SurveyOnboardingBackgroundView to be a generic OppiaCurveBac…

3435a08

…kgroundView Since many new designs include this custom shape, we can now reuse this view by passing in the desired background color.

Add onboarding language selection layout: wip

4df3f60

sync with develop and resolve conflicts

0f6c4b9

Rename platform parameter to enableOnboardingFlowV2

76120a9

Merge remote-tracking branch 'upstream/new-onboarding-platform-param'…

b76679b

… into new-onboarding-ui # Conflicts: # app/src/main/res/values/dimens.xml

Create onboarding app language selection UI portrait

4345801

Complete onboarding language UI portrait light mode

3f28f81

Add darkmode support for onboarding language UI

c2fa816

Fix explanation text padding

ee9ff7c

Revert commented out code

6f0f6e4

Set up new onboarding flow entry point

52ae374

Set up onboarding fragment tests wth platform param

b04b637

Add onboarding profile type selection UI and navigation

a536e15

Add onboarding profile type selection UI and navigation

91fb562

merge upstream/develop

7962902

Move feature flags to FeatureFlagConstants.kt

0696b6a

Merge branch 'new-onboarding-platform-param' into new-onboarding-ui

296c4d1

adhiamboperes self-assigned this Jan 31, 2024

adhiamboperes requested review from a team as code owners January 31, 2024 20:36

adhiamboperes requested review from BenHenning and removed request for a team January 31, 2024 20:36

adhiamboperes changed the title ~~Fix Part of #4938: Introduce Onboarding UI V2~~ Fix Part of #4938: Introduce Onboarding UI V2 2 of 3 Jan 31, 2024

adhiamboperes added 3 commits February 1, 2024 17:27

Added learner welcome screen

2e0c8b8

Added audio language selection screen

a0a553a

Fix bazel error

dd197e2

adhiamboperes commented Feb 2, 2024

View reviewed changes

adhiamboperes commented Feb 16, 2024

View reviewed changes

adhiamboperes added 12 commits February 20, 2024 00:23

Fix review pass issues

edbdb11

App language tests

6c9086b

Create test file exemptions

5adb3e2

Merge branch 'new-onboarding-ui' of github.com:oppia/oppia-android in…

133cf98

…to new-onboarding-ui

Wrap up activity tests

c6c0174

Merge branch 'develop' of github.com:oppia/oppia-android into new-onb…

7f861b3

…oarding-ui

Fix missing test configs

8a271fa

Fragment tests

dc9557b

Fragment tests

69c1eae

audio and new profile

Fix profile type tests and display on very small devices

6a0fd44

Fix landscape tests and display on very small devices

cc2cce0

Merge branch 'develop' into new-onboarding-ui

6c07b96

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 5, 2024

oppiabot bot closed this Mar 12, 2024

adhiamboperes reopened this Mar 13, 2024

oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 13, 2024

adhiamboperes commented Mar 13, 2024

View reviewed changes

adhiamboperes added 8 commits March 16, 2024 18:39

Profile picture upload success

f478aef

refactor create profile classes

ee37115

Create profile and display name in next screen

f3e485a

Navigate to audio language fragment and show list of languages in dro…

dcf35c3

…pdown.

Implement navigation to home screen

7e53496

Fix failing tests

cf918e9

Merge branch 'new-onboarding-ui' of github.com:oppia/oppia-android in…

deacb45

…to new-onboarding-ui

Merge branch 'develop' of github.com:oppia/oppia-android into new-onb…

692e62e

…oarding-ui

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 26, 2024

oppiabot bot closed this Apr 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Part of #4938: Introduce Onboarding UI V2 2 of 3 #5327

Fix Part of #4938: Introduce Onboarding UI V2 2 of 3 #5327

adhiamboperes commented Jan 31, 2024 •

edited

Loading

adhiamboperes left a comment

adhiamboperes left a comment

oppiabot bot commented Mar 5, 2024

adhiamboperes left a comment

adhiamboperes Mar 13, 2024

adhiamboperes Mar 13, 2024

adhiamboperes Mar 13, 2024

oppiabot bot commented Mar 26, 2024

Fix Part of #4938: Introduce Onboarding UI V2 2 of 3 #5327

Fix Part of #4938: Introduce Onboarding UI V2 2 of 3 #5327

Conversation

adhiamboperes commented Jan 31, 2024 • edited Loading

Explanation

Essential Checklist

For UI-specific PRs only

Mobile

Tablet

adhiamboperes left a comment

Choose a reason for hiding this comment

adhiamboperes left a comment

Choose a reason for hiding this comment

oppiabot bot commented Mar 5, 2024

adhiamboperes left a comment

Choose a reason for hiding this comment

adhiamboperes Mar 13, 2024

Choose a reason for hiding this comment

adhiamboperes Mar 13, 2024

Choose a reason for hiding this comment

adhiamboperes Mar 13, 2024

Choose a reason for hiding this comment

oppiabot bot commented Mar 26, 2024

adhiamboperes commented Jan 31, 2024 •

edited

Loading