-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #5070: Display empty answer message in drag & drop sort interaction #5323
Fix part of #5070: Display empty answer message in drag & drop sort interaction #5323
Conversation
Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
…upport' into feat/drag-drop-ui-empty-answer-support
@adhiamboperes PTAL. |
Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17!
PTAL.
...java/org/oppia/android/app/player/state/itemviewmodel/DragAndDropSortInteractionViewModel.kt
Outdated
Show resolved
Hide resolved
...java/org/oppia/android/app/player/state/itemviewmodel/DragAndDropSortInteractionViewModel.kt
Outdated
Show resolved
Hide resolved
Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17. I tested this code manually and noticed a bug. PTAL.
...java/org/oppia/android/app/player/state/itemviewmodel/DragAndDropSortInteractionViewModel.kt
Outdated
Show resolved
Hide resolved
Unassigning @adhiamboperes since the review is done. |
Hi @theMr17, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
Please also add tests to verify that the submit button is re-enabled and the error message is hidden once a drag/sort interaction occurs. |
@adhiamboperes PTAL. I have made the requested changes and have also added tests to verify that the submit button is re-enabled and the error message is hidden once a drag/sort interaction occurs for both grouping and non-grouping drag & drop interactions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17! This LGTM.
Unassigning @adhiamboperes since they have already approved the PR. |
Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fixes part of #5070
Enables the
submit_answer_button
when the pending answer is empty. Instead of disabling the button, an error message, stating "Arrange the boxes to continue.", is now displayed when the user attempts to submit without arranging the boxes.Screen.Recording.mp4
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: