Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5070: Display empty answer message in drag & drop sort interaction #5323

Merged

Conversation

theMr17
Copy link
Collaborator

@theMr17 theMr17 commented Jan 27, 2024

Explanation

Fixes part of #5070

Enables the submit_answer_button when the pending answer is empty. Instead of disabling the button, an error message, stating "Arrange the boxes to continue.", is now displayed when the user attempts to submit without arranging the boxes.

Screen.Recording.mp4

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@theMr17 theMr17 self-assigned this Jan 27, 2024
Copy link

oppiabot bot commented Feb 4, 2024

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 4, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 4, 2024
@theMr17 theMr17 marked this pull request as ready for review February 5, 2024 16:25
@theMr17 theMr17 requested review from a team as code owners February 5, 2024 16:25
@theMr17 theMr17 requested a review from adhiamboperes February 5, 2024 16:25
@theMr17
Copy link
Collaborator Author

theMr17 commented Feb 5, 2024

@adhiamboperes PTAL.

@oppiabot oppiabot bot assigned adhiamboperes and unassigned theMr17 Feb 5, 2024
Copy link

oppiabot bot commented Feb 5, 2024

Unassigning @theMr17 since a re-review was requested. @theMr17, please make sure you have addressed all review comments. Thanks!

Copy link

oppiabot bot commented Feb 12, 2024

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 12, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 12, 2024
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theMr17!

PTAL.

@adhiamboperes adhiamboperes removed their assignment Feb 26, 2024
@theMr17 theMr17 assigned adhiamboperes and unassigned theMr17 Mar 1, 2024
Copy link

oppiabot bot commented Mar 8, 2024

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 8, 2024
@theMr17 theMr17 removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 10, 2024
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theMr17. I tested this code manually and noticed a bug. PTAL.

Copy link

oppiabot bot commented Mar 15, 2024

Unassigning @adhiamboperes since the review is done.

Copy link

oppiabot bot commented Mar 15, 2024

Hi @theMr17, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@adhiamboperes
Copy link
Collaborator

Please also add tests to verify that the submit button is re-enabled and the error message is hidden once a drag/sort interaction occurs.

@theMr17
Copy link
Collaborator Author

theMr17 commented Mar 18, 2024

@adhiamboperes PTAL. I have made the requested changes and have also added tests to verify that the submit button is re-enabled and the error message is hidden once a drag/sort interaction occurs for both grouping and non-grouping drag & drop interactions.

@oppiabot oppiabot bot assigned adhiamboperes and unassigned theMr17 Mar 18, 2024
Copy link

oppiabot bot commented Mar 18, 2024

Unassigning @theMr17 since a re-review was requested. @theMr17, please make sure you have addressed all review comments. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theMr17! This LGTM.

@adhiamboperes adhiamboperes enabled auto-merge (squash) March 18, 2024 06:48
Copy link

oppiabot bot commented Mar 18, 2024

Unassigning @adhiamboperes since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Mar 18, 2024
Copy link

oppiabot bot commented Mar 18, 2024

Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes merged commit 14a43d1 into oppia:develop Mar 18, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants