-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5143: Update Robolectric to 4.7 #5322
Conversation
Hi! @sandy99405 Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sandy99405!
- Could you please also update the robolectric versions in the
build.gradle
files for app, domain, utility and testing modules? - The PR description has a checklist of what the PR should look like, mainly the Explanation bit and the title bit. Could you ensure this PR is compliant? You can copy the template from a different PR like Fix part of #5070: Display empty answer message in number input interaction #5310
@adhiamboperes can you kindly confirm if I have to change Robolectric version in data and maven_install.json as well? |
Yes, in data too. You can search each of the build.gradle files for ocurrances of robolectric and espresso-core to make sure you don't miss anything. maven_install.json is specific to bazel and it is never updated manually -- it uses the update script that you previously ran. |
Thank you for the confirmation @adhiamboperes 👍 |
@adhiamboperes , may I close this PR and create a new one? Because I erased all the rules before writing the comment and I don't know where to find the checklist rules. Please help |
Please copy the template from here: https://github.com/oppia/oppia-android/blob/develop/.github/PULL_REQUEST_TEMPLATE.md?plain=1 |
Signed-off-by: sandy99405 <[email protected]>
All the changes are done @adhiamboperes. BTW the git-hub actions asked me to fill out the CLA sheet only then the PR will be accepted. It's this form right? Do I have to talk to you guys and stuff after filling out the form? |
Hi @adhiamboperes all the conflicts and updates have been finished. Please check this PR. |
Explanation
According to issue #5143, there was an error
unexpected element <queries> found in <manifest>
during the Bazel build.That issue has been resolved in this PR.
Robolectric version has been changed to 4.7 and espresso-core to 3.5.0-alpha03 in every build.gadle file
In scripts/assets folder, the maven_dependencies.textproto file has been changed due to an exception.
This is the Bazel output after updating the Robolectric to 4.7 and maven_install
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: