Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4135: Remove leftover TODO #5321

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

masclot
Copy link
Collaborator

@masclot masclot commented Jan 25, 2024

Explanation

Fix #4135: The only thing left is removing the TODO comment, as the tests were created in #5224

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@masclot masclot requested a review from a team as a code owner January 25, 2024 09:10
@masclot masclot requested a review from adhiamboperes January 25, 2024 09:10
@masclot
Copy link
Collaborator Author

masclot commented Jan 25, 2024

PTAL @adhiamboperes

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @masclot!

@adhiamboperes adhiamboperes enabled auto-merge (squash) January 26, 2024 11:11
@oppiabot oppiabot bot added the PR: LGTM label Jan 26, 2024
Copy link

oppiabot bot commented Jan 26, 2024

Hi @masclot, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes merged commit f5be6f6 into oppia:develop Jan 26, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for FractionInputInteractionView
2 participants