-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #5243: Technical Analytics Milestone 3 - New App Health Metrics #5320
Fixes #5243: Technical Analytics Milestone 3 - New App Health Metrics #5320
Conversation
…d failed retrofit calls
…a/oppia-android into technical-analytics-milestone-3
Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kkmurerwa! I left a couple of minor comments, but I would still like you to further change the network test names. Please see inline.
...src/main/java/org/oppia/android/domain/oppialogger/analytics/ApplicationLifecycleObserver.kt
Outdated
Show resolved
Hide resolved
...test/java/org/oppia/android/domain/oppialogger/analytics/ApplicationLifecycleObserverTest.kt
Outdated
Show resolved
Hide resolved
data/src/test/java/org/oppia/android/data/backends/gae/NetworkLoggingInterceptorTest.kt
Outdated
Show resolved
Hide resolved
Hi @adhiamboperes. I have made the changes suggested. PTAL |
Unassigning @kkmurerwa since a re-review was requested. @kkmurerwa, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kkmurerwa! LGTM.
Please address the remaining comment before merge.
data/src/test/java/org/oppia/android/data/backends/gae/NetworkLoggingInterceptorTest.kt
Outdated
Show resolved
Hide resolved
Hi @kkmurerwa, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fixes #5243: When merged, this PR will;
ConsoleLogger
.Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: