-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #5261: InefficientWeight #5297
Fix part of #5261: InefficientWeight #5297
Conversation
… to line 34 in view_event_logs_event_log_item_view.xml
@adhiamboperes PTAL |
Hi @deonwaju, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
… to line 34 in view_event_logs_event_log_item_view.xml
… to line 34 in view_event_logs_event_log_item_view.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @deonwaju, please attach screenshots of the layout before and after as per PR guidelines and also a screenshot of the latest linnt check.
PTAL @adhiamboperes |
@deonwaju, by layout screenshots I meant of the app running on a device/emulator and showing the screen where the changes were made. This is the only way to confirm the layout looks okay. Once done please reassign to me. |
PTAL @adhiamboperes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @deonwaju!
Hi @deonwaju, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fix part of #5261
(A) Added android:layout_width="0dp" to line 34 in view_event_logs_event_log_item_view.xml
Layout
Before:
After:
Lint Check
Before:
After:
Essential Checklist