Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5261: InefficientWeight #5297

Merged
merged 5 commits into from
Jan 28, 2024

Conversation

deonwaju
Copy link
Collaborator

@deonwaju deonwaju commented Jan 11, 2024

Explanation

Fix part of #5261
(A) Added android:layout_width="0dp" to line 34 in view_event_logs_event_log_item_view.xml

Layout

Before:
before

After:
after

Lint Check

Before:
Screenshot 2024-01-20 at 14 14 24

After:
Screenshot 2024-01-20 at 15 09 13

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

… to line 34 in view_event_logs_event_log_item_view.xml
@deonwaju deonwaju requested a review from a team as a code owner January 11, 2024 01:16
@deonwaju
Copy link
Collaborator Author

@adhiamboperes PTAL

Copy link

oppiabot bot commented Jan 18, 2024

Hi @deonwaju, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 18, 2024
… to line 34 in view_event_logs_event_log_item_view.xml
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 18, 2024
… to line 34 in view_event_logs_event_log_item_view.xml
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @deonwaju, please attach screenshots of the layout before and after as per PR guidelines and also a screenshot of the latest linnt check.

@deonwaju
Copy link
Collaborator Author

PTAL @adhiamboperes

@oppiabot oppiabot bot assigned adhiamboperes and unassigned deonwaju Jan 20, 2024
Copy link

oppiabot bot commented Jan 20, 2024

Unassigning @deonwaju since a re-review was requested. @deonwaju, please make sure you have addressed all review comments. Thanks!

@adhiamboperes
Copy link
Collaborator

@deonwaju, by layout screenshots I meant of the app running on a device/emulator and showing the screen where the changes were made. This is the only way to confirm the layout looks okay. Once done please reassign to me.

@deonwaju
Copy link
Collaborator Author

PTAL @adhiamboperes

@oppiabot oppiabot bot assigned adhiamboperes and unassigned deonwaju Jan 23, 2024
Copy link

oppiabot bot commented Jan 23, 2024

Unassigning @deonwaju since a re-review was requested. @deonwaju, please make sure you have addressed all review comments. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @deonwaju!

Copy link

oppiabot bot commented Jan 26, 2024

Hi @deonwaju, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes enabled auto-merge (squash) January 28, 2024 19:26
@adhiamboperes adhiamboperes merged commit 60de5db into oppia:develop Jan 28, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants