Fix #4206 Create New HtmlParser Factory Method

app/src/main/java/org/oppia/android/app/devoptions/mathexpressionparser/MathExpressionParserViewModel.kt

@@ -31,12 +31,7 @@ class MathExpressionParserViewModel @Inject constructor(
   private val htmlParserFactory: HtmlParser.Factory
 ) : ObservableViewModel() {
   private val htmlParser by lazy {
-    // TODO(#4206): Replace this with the variant that doesn't require GCS properties.
     htmlParserFactory.create(
-      gcsResourceName = "",
-      entityType = "",
-      entityId = "",
-      imageCenterAlign = false,
       displayLocale = appLanguageResourceHandler.getDisplayLocale()
     )
   }

utility/src/main/java/org/oppia/android/util/parser/html/HtmlParser.kt

@@ -78,7 +78,6 @@ class HtmlParser private constructor(
     supportsLinks: Boolean = false,
     supportsConceptCards: Boolean = false
   ): Spannable {
-
     var htmlContent = rawString
 
     // Canvas does not support RTL, it always starts from left to right in RTL due to which compound drawables are
@@ -124,11 +123,17 @@ class HtmlParser private constructor(
     }
 
     val imageGetter = urlImageParserFactory?.create(
-      htmlContentTextView, gcsResourceName, entityType, entityId, imageCenterAlign
+      htmlContentTextView,
+      gcsResourceName,
+      entityType,
+      entityId,
+      imageCenterAlign
     )
 
     val htmlSpannable = CustomHtmlContentHandler.fromHtml(
-      htmlContent, imageGetter, computeCustomTagHandlers(supportsConceptCards, htmlContentTextView)
+      htmlContent,
+      imageGetter,
+      computeCustomTagHandlers(supportsConceptCards, htmlContentTextView)
     )
 
     val urlPattern = Patterns.WEB_URL
@@ -235,7 +240,30 @@ class HtmlParser private constructor(
         consoleLogger,
         cacheLatexRendering = enableCacheLatexRendering.value,
         customOppiaTagActionListener,
-        null,
+        policyOppiaTagActionListener = null,
+        displayLocale
+      )
+    }
+
+    /**
+     * Returns a new [HtmlParser] with the empty entity type and ID for loading images,
+     * doesn't require GCS properties and imageCenterAlign set to false
+     * optionally specified [CustomOppiaTagActionListener] for handling custom Oppia tag events.
+     */
+    fun create(
+      displayLocale: OppiaLocale.DisplayLocale
+    ): HtmlParser {
+      return HtmlParser(
+        context,
+        urlImageParserFactory,
+        gcsResourceName = "",
+        entityType = "",
+        entityId = "",
+        imageCenterAlign = false,
+        consoleLogger,
+        cacheLatexRendering = enableCacheLatexRendering.value,
+        customOppiaTagActionListener = null,
+        policyOppiaTagActionListener = null,
         displayLocale
       )
     }