Fixed #2652 #5265
Fixed #2652 #5265
Conversation
There was a problem hiding this comment.
Thanks @Cyclotron17!
In addition to the comments I have left inline, I have noticed that you haven't added the bazel dependency in the project.
The library needs to be added to bazel as well as gradle. Please follow this wiki to add a dependency to bazel. Here is a commit that shows an example of what is expected when adding a new dependency to bazel: c85a6e6.
Please ask a question for any clarifications needed.
| 'com.github.oppia:android-spotlight:ebde38335bfb56349eae57e705b611ead9addb15' | ||
| 'com.github.oppia:android-spotlight:ebde38335bfb56349eae57e705b611ead9addb15', | ||
|
|
||
| //Sambhrant Tiwari |
There was a problem hiding this comment.
Please remove the comment. All attributions are handled by git when you make a commit with your username.
|
|
||
| //Sambhrant Tiwari | ||
| 'com.intuit.ssp:ssp-android:1.0.5', | ||
| 'com.intuit.sdp:sdp-android:1.0.5' |
There was a problem hiding this comment.
I think adding the sdp lib only is sufficient, and there is a newer version, 'com.intuit.sdp:sdp-android:1.1.0',
| android:layout_width="@dimen/width_228dp" | ||
| android:layout_height="@dimen/height_88dp" |
There was a problem hiding this comment.
| android:layout_width="@dimen/width_228dp" | |
| android:layout_height="@dimen/height_88dp" | |
| android:layout_width="@dimen/splash_imageview_width" | |
| android:layout_height="@dimen/splash_imageview_height" |
| <dimen name="width_228dp">228dp</dimen> | ||
|
|
||
| <!-- Example dimension for height --> | ||
| <dimen name="height_88dp">88dp</dimen> |
There was a problem hiding this comment.
This file is organized according to screen name, kindly add splash screen related dimens under the relevant category, or create one if it does not exist. Please stick to the patterns in the file.
Additionally, Your dimensions are in dp, contrary to the fix you proposed in #2652 (comment).
Just adding the dependency and not using it does not fix the issue.
|
Sure thing, will make the required changes and re raise the PR. |
|
Hi @Cyclotron17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
oppiabot
bot
added
the
stale
Vishwajith-Shettigar
removed
the
stale
|
Hi @Cyclotron17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
oppiabot
bot
added
the
stale
untitled.webm
6inch.webm
Resolved the Streched Splash Screen issue in both mobile phones of sizes 6 inches or more and on Tablets, added the bazel dependency as well , please review it once.
earlier the splash screen use to look like this
