Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5070: Display empty answer message in ratio input interaction #5263

Merged
merged 21 commits into from
Jan 11, 2024

Conversation

theMr17
Copy link
Collaborator

@theMr17 theMr17 commented Dec 8, 2023

Explanation

Fixes part of #5070

Enables the submit_answer_button when the pending answer is empty. Instead of disabling the button, an error message, stating "Enter a ratio to continue.", is now displayed when the user attempts to submit a blank answer.

RatioInputInteractionViewTestActivity is added to accessibility-label exemption as this is a test activity.

Screen.Recording.mp4

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@adhiamboperes
Copy link
Collaborator

@theMr17 is this ready for a full pass or are you looking for a preliminary review on approach? Please convert to ready and assign to me if the former.

@theMr17
Copy link
Collaborator Author

theMr17 commented Dec 11, 2023

@adhiamboperes, please do a preliminary review of the approach. I will proceed to write tests after that.

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theMr17, I have left some suggestions, but the overall approach looks good to me.

@theMr17 theMr17 marked this pull request as ready for review December 17, 2023 05:35
@theMr17 theMr17 requested review from a team as code owners December 17, 2023 05:35
@theMr17 theMr17 requested a review from BenHenning December 17, 2023 05:35
@theMr17
Copy link
Collaborator Author

theMr17 commented Dec 17, 2023

@adhiamboperes PTAL

@oppiabot oppiabot bot assigned adhiamboperes and unassigned theMr17 Dec 17, 2023
Copy link

oppiabot bot commented Dec 17, 2023

Unassigning @theMr17 since a re-review was requested. @theMr17, please make sure you have addressed all review comments. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theMr17! This LGTM.

Thanks for moving the ratio tests to their own suite as well.

@adhiamboperes adhiamboperes enabled auto-merge (squash) December 18, 2023 08:25
Copy link

oppiabot bot commented Dec 18, 2023

Unassigning @adhiamboperes since they have already approved the PR.

Copy link

oppiabot bot commented Dec 18, 2023

Assigning @BenHenning for code owner reviews. Thanks!

Copy link

oppiabot bot commented Dec 25, 2023

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 25, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 25, 2023
Copy link

oppiabot bot commented Jan 1, 2024

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 1, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 3, 2024
@adhiamboperes
Copy link
Collaborator

@BenHenning, this PR is blocked on codeowner, PTAL.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theMr17! Really sorry about the late review here. I just had two small comments, otherwise the PR LGTM.

@BenHenning BenHenning assigned theMr17 and unassigned BenHenning Jan 9, 2024
@theMr17
Copy link
Collaborator Author

theMr17 commented Jan 11, 2024

@BenHenning PTAL

@oppiabot oppiabot bot assigned BenHenning and unassigned theMr17 Jan 11, 2024
Copy link

oppiabot bot commented Jan 11, 2024

Unassigning @theMr17 since a re-review was requested. @theMr17, please make sure you have addressed all review comments. Thanks!

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theMr17! Please make sure to respond to addressed comments on future PRs. Otherwise the PR LGTM.

@BenHenning BenHenning merged commit bb69b22 into oppia:develop Jan 11, 2024
36 checks passed
@theMr17
Copy link
Collaborator Author

theMr17 commented Jan 12, 2024

Thanks @theMr17! Please make sure to respond to addressed comments on future PRs. Otherwise the PR LGTM.

Thanks @BenHenning, I will surely keep that in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants