Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5261: DisableBaselineAlignment #5262

Merged

Conversation

deonwaju
Copy link
Collaborator

@deonwaju deonwaju commented Dec 7, 2023

Explanation

Fix part of #5261
(A) Add android:baselineAligned="false" to LinearLayout on line 12 in "layout-sw600dp-land/topic_info_fragment.xml"
(B) Add android:baselineAligned="false" to LinearLayout on line 91 in "
"layout/topic_lessons_story_summary.xml"
(C) Add android:baselineAligned="false" to LinearLayout on line 93 in "
"layout-sw600dp-land/topic_lessons_story_summary.xml"

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@deonwaju deonwaju requested a review from a team as a code owner December 7, 2023 10:22
@deonwaju
Copy link
Collaborator Author

deonwaju commented Dec 7, 2023

@adhiamboperes PTAL

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @deonwaju!

@adhiamboperes adhiamboperes merged commit d85fe6e into oppia:develop Dec 7, 2023
37 checks passed
@deonwaju deonwaju deleted the feature/disableBaselineAlignment branch December 8, 2023 09:36
@deonwaju deonwaju restored the feature/disableBaselineAlignment branch December 8, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants