Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5251: Modify Feature Flag Names to reflect those on Oppia Web #5260

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

Tejas-67
Copy link
Contributor

@Tejas-67 Tejas-67 commented Dec 5, 2023

Explanation

Modified feature flag names as proposed to reflect those on oppia web.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@Tejas-67
Copy link
Contributor Author

Tejas-67 commented Dec 5, 2023

@adhiamboperes please check.

@adhiamboperes
Copy link
Collaborator

@Tejas-67, I have taken a look, but the PR is still in draft. Are you still doing some work on it?

@Tejas-67 Tejas-67 marked this pull request as ready for review December 6, 2023 06:19
@Tejas-67 Tejas-67 requested a review from a team as a code owner December 6, 2023 06:19
@Tejas-67 Tejas-67 requested a review from BenHenning December 6, 2023 06:19
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @Tejas-67!

@adhiamboperes adhiamboperes enabled auto-merge (squash) December 6, 2023 13:46
Copy link

oppiabot bot commented Dec 6, 2023

Assigning @BenHenning for code owner reviews. Thanks!

@adhiamboperes adhiamboperes merged commit 3dee20b into oppia:develop Dec 6, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants