Fix #5251 Modify Feature Flag Names to reflect those on Oppia Web #5257
Conversation
… link and should be clickable.
- Replace brittle string manipulation with robust regex matching using .toRegex().find() - Introduce new helper functions for code simplification
- Replace brittle string manipulation with robust regex matching using .toRegex().find() - Introduce new helper functions for code simplification
There was a problem hiding this comment.
Thanks @Tejas-67!
Your changes on the FeatureFlagConstants look good, but the remaining file changes need to be reverted.
Whenever creating a new PR, you should create a new branch based off of the develop branch. You can do this by:
git checkout developcheckout your local developgit pull upstream developsync with upstreamgit checkout -b new-branch-namecreate clean branch
In case you had mistakenly made commits on you local develop branch, you can do a hard reset or delete the branch and checkout a clean one from upstream.
| policyDescription = resourceHandler.getStringInLocale(R.string.privacy_policy_content) | ||
| policyWebLink = resourceHandler.getStringInLocale(R.string.privacy_policy_web_link) | ||
| } else if (policyPage == PolicyPage.TERMS_OF_SERVICE) { | ||
| policyDescription = | ||
| resourceHandler.getStringInLocale(R.string.terms_of_service_content) | ||
| policyDescription = resourceHandler.getStringInLocale(R.string.terms_of_service_content) |
There was a problem hiding this comment.
These changes are not related to this PR. Please revert
| @@ -236,4 +236,4 @@ | |||
| <li>26 Sep 2015: Revised terms added.</li> | |||
| </ul> | |||
| </]]></string> | |||
There was a problem hiding this comment.
This file change too is not related to this PR.
There was a problem hiding this comment.
This file should not be part of this PR
|
@adhiamboperes Okay, I will close this PR and create a fresh one. |
Explanation
Modified feature flag names to respective new names as described here.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: