-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #2480: Fixes 2 Audio Tests #5245
Conversation
@theMr17, could you please walk me through the solution that you are trying to achieve in this PR? |
@adhiamboperes, By this PR, I am trying to figure out exactly why the tests are failing in #2480 and finding a fix a for it. |
@adhiamboperes PTAL |
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt
Outdated
Show resolved
Hide resolved
Unassigning @adhiamboperes since the review is done. |
Hi @theMr17, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17! This LGTM.
Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fixes part of #2480
testAudioWifi_ratioExp_audioIcon_audioFragHasDefaultLangAndAutoPlays()
by checking default language at the end and testing audio icons in a better way.testAudioWifi_ratioExp_continueInteraction_audioButton_submitAns_feedbackAudioPlays()
by scrolling to the continue_interaction_button before performing click on it , as it was positioned at the lower end of the recycler view.Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: