Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #2480: Fixes 2 Audio Tests #5245

Merged
merged 70 commits into from
Dec 7, 2023

Conversation

theMr17
Copy link
Collaborator

@theMr17 theMr17 commented Nov 25, 2023

Explanation

Fixes part of #2480

  • Fixes testAudioWifi_ratioExp_audioIcon_audioFragHasDefaultLangAndAutoPlays() by checking default language at the end and testing audio icons in a better way.
  • Fixes testAudioWifi_ratioExp_continueInteraction_audioButton_submitAns_feedbackAudioPlays() by scrolling to the continue_interaction_button before performing click on it , as it was positioned at the lower end of the recycler view.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link

Hi! @theMr17 Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks!

@adhiamboperes
Copy link
Collaborator

@theMr17, could you please walk me through the solution that you are trying to achieve in this PR?

@theMr17
Copy link
Collaborator Author

theMr17 commented Nov 29, 2023

@adhiamboperes, By this PR, I am trying to figure out exactly why the tests are failing in #2480 and finding a fix a for it.

@theMr17 theMr17 changed the title Fixing Audio Tests Fix part of #2480: Fixes 2 Audio Tests Dec 7, 2023
@theMr17 theMr17 marked this pull request as ready for review December 7, 2023 08:38
@theMr17 theMr17 requested a review from a team as a code owner December 7, 2023 08:38
@theMr17 theMr17 requested a review from adhiamboperes December 7, 2023 08:38
@theMr17
Copy link
Collaborator Author

theMr17 commented Dec 7, 2023

@adhiamboperes PTAL

@oppiabot oppiabot bot assigned adhiamboperes and unassigned theMr17 Dec 7, 2023
Copy link

oppiabot bot commented Dec 7, 2023

Unassigning @theMr17 since a re-review was requested. @theMr17, please make sure you have addressed all review comments. Thanks!

Copy link

oppiabot bot commented Dec 7, 2023

Unassigning @adhiamboperes since the review is done.

Copy link

oppiabot bot commented Dec 7, 2023

Hi @theMr17, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theMr17! This LGTM.

@oppiabot oppiabot bot added the PR: LGTM label Dec 7, 2023
Copy link

oppiabot bot commented Dec 7, 2023

Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes enabled auto-merge (squash) December 7, 2023 22:54
@adhiamboperes adhiamboperes merged commit d021afd into oppia:develop Dec 7, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants