Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix All warnings in "Usability:Typography", "Usability:Icons", and "Usability" categories #5196

Merged
merged 20 commits into from
Jan 9, 2024

Conversation

Rd4dev
Copy link
Collaborator

@Rd4dev Rd4dev commented Oct 17, 2023

Explanation

Fixes #5194 [part of #5182]

Fixes all warning in "Usability" category caused by

  • Borderless Buttons : Fixed by introducing style="?android:attr/buttonBarButtonStyle" to the borderless buttons
  • OK text capitalization : Fixed by suppressing the lint warnings for ButtonCase and Typos
  • Ellipsis/Hyphen unicode replacement : Fixed by introducing unicode representations (under review)
  • Image in density drawable folder : Fixed by creating seperate density images (under review)
  • Text size too small : Fixed by upscaling text size to 12sp
  • To incorporate Autofill : Fixed by incorporating autofillHints to the EditText

ScreenShot

Before After Usability Lint Issues

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@Rd4dev Rd4dev requested review from a team as code owners October 17, 2023 11:14
@Rd4dev Rd4dev requested a review from BenHenning October 17, 2023 11:14
@adhiamboperes adhiamboperes added the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 18, 2023
@oppiabot
Copy link

oppiabot bot commented Oct 25, 2023

Hi @Rd4dev, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 25, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 26, 2023
@adhiamboperes adhiamboperes removed the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 31, 2023
Copy link

oppiabot bot commented Nov 7, 2023

Hi @Rd4dev, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 7, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 10, 2023
Copy link

oppiabot bot commented Nov 17, 2023

Hi @Rd4dev, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 17, 2023
@adhiamboperes
Copy link
Collaborator

@Rd4dev, it seems that all the concerns have been addressed in the issue thread. Please update the PR and reassign for review.

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 21, 2023
@Rd4dev
Copy link
Collaborator Author

Rd4dev commented Nov 22, 2023

@adhiamboperes, as suggested in the #5169, I had kept the unicode changes -> [changes mentioned], updated the PR with the latest changes and merged them.

@Rd4dev
Copy link
Collaborator Author

Rd4dev commented Nov 22, 2023

Hi @adhiamboperes, the task has already been assigned to @BenHenning, and I'm unable to find an option to reassign it for review. Is there a specific process or action I should take to assign a reviewer again?
Web capture_22-11-2023_19111_github com

@adhiamboperes
Copy link
Collaborator

adhiamboperes commented Nov 22, 2023

@Rd4dev, per wiki, you need to do a top level comment like: "@ReviewerName, PTAL". In this case, reviewer is me.

This is for the Assignees' section

@Rd4dev
Copy link
Collaborator Author

Rd4dev commented Nov 22, 2023

@Rd4dev, per wiki, you need to do a top level comment like: "@ReviewerName, PTAL". In this case, reviewer is me.

This is for the Assignees' section

@adhiamboperes Got it, thanks! Will make sure to refer the wiki for future queries.

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 9, 2023
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rd4dev! Apologies for my delayed review here. The PR generally looks really good--just had a few comments. PTAL.

@BenHenning BenHenning assigned Rd4dev and unassigned BenHenning Dec 12, 2023
Copy link

oppiabot bot commented Dec 19, 2023

Hi @Rd4dev, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 19, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 21, 2023
Copy link

oppiabot bot commented Dec 28, 2023

Hi @Rd4dev, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added stale Corresponds to items that haven't seen a recent update and may be automatically closed. and removed stale Corresponds to items that haven't seen a recent update and may be automatically closed. labels Dec 28, 2023
@Rd4dev
Copy link
Collaborator Author

Rd4dev commented Dec 31, 2023

@BenHenning PTAL - review

@Rd4dev Rd4dev requested a review from BenHenning December 31, 2023 21:58
@oppiabot oppiabot bot assigned adhiamboperes and unassigned Rd4dev Dec 31, 2023
Copy link

oppiabot bot commented Dec 31, 2023

Unassigning @Rd4dev since a re-review was requested. @Rd4dev, please make sure you have addressed all review comments. Thanks!

@adhiamboperes adhiamboperes removed their assignment Jan 3, 2024
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rd4dev! Really sorry about the delayed review. The PR LGTM.

@BenHenning BenHenning enabled auto-merge (squash) January 9, 2024 17:33
Copy link

oppiabot bot commented Jan 9, 2024

Unassigning @BenHenning since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jan 9, 2024
Copy link

oppiabot bot commented Jan 9, 2024

Hi @Rd4dev, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@oppiabot oppiabot bot assigned Rd4dev Jan 9, 2024
@BenHenning BenHenning merged commit 9ad24ef into oppia:develop Jan 9, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All warnings in "Usability:Typography", "Usability:Icons", and "Usability" categories
3 participants