-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix All warnings in "Usability:Typography", "Usability:Icons", and "Usability" categories #5196
Conversation
Hi @Rd4dev, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
…o Issue#5169-Usability
…a-android into Issue#5169-Usability
Hi @Rd4dev, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
…o Issue#5169-Usability
Hi @Rd4dev, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
@Rd4dev, it seems that all the concerns have been addressed in the issue thread. Please update the PR and reassign for review. |
…o Issue#5169-Usability
@adhiamboperes, as suggested in the #5169, I had kept the unicode changes -> [changes mentioned], updated the PR with the latest changes and merged them. |
Hi @adhiamboperes, the task has already been assigned to @BenHenning, and I'm unable to find an option to reassign it for review. Is there a specific process or action I should take to assign a reviewer again? |
@adhiamboperes Got it, thanks! Will make sure to refer the wiki for future queries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Rd4dev! Apologies for my delayed review here. The PR generally looks really good--just had a few comments. PTAL.
Hi @Rd4dev, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
…o Issue#5169-Usability
…a-android into Issue#5169-Usability
Hi @Rd4dev, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
@BenHenning PTAL - review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Rd4dev! Really sorry about the delayed review. The PR LGTM.
Unassigning @BenHenning since they have already approved the PR. |
Hi @Rd4dev, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fixes #5194 [part of #5182]
Fixes all warning in "Usability" category caused by
style="?android:attr/buttonBarButtonStyle"
to the borderless buttonsButtonCase
andTypos
12sp
autofillHints
to the EditTextScreenShot
Essential Checklist