Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #5182 - All warnings in "Internationalization" #5183

Merged
merged 5 commits into from
Oct 14, 2023
Merged

Fixed #5182 - All warnings in "Internationalization" #5183

merged 5 commits into from
Oct 14, 2023

Conversation

Rd4dev
Copy link
Collaborator

@Rd4dev Rd4dev commented Oct 9, 2023 •
edited
Loading

Explanation

Fix #5182 [part of #5169]

Fixes All warnings in "Internationalization" caused by

  • hardcoded text : Fixed by assigning string resource values
  • padding/margins : Fixed by setting padding end values

ScreenShot:

Lint Issues Internationalization Before After

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@Rd4dev Rd4dev requested a review from a team as a code owner October 9, 2023 18:00
@Rd4dev Rd4dev requested a review from adhiamboperes October 9, 2023 18:00
adhiamboperes
adhiamboperes requested changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rd4dev!

I have requested changes inline.

app/src/main/res/layout-sw600dp/administrator_controls_learner_analytics_view.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/activity_input_interaction_view_test.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/activity_input_interaction_view_test.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/activity_input_interaction_view_test.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/spotlight_fragment_test_activity.xml Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Oct 14, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented Oct 14, 2023

Hi @Rd4dev, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@Rd4dev
Copy link
Collaborator Author

Rd4dev commented Oct 14, 2023

Thank you for the review @adhiamboperes. I have incorporated the requested changes!

@Rd4dev Rd4dev requested a review from adhiamboperes October 14, 2023 08:52
adhiamboperes
adhiamboperes approved these changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rd4dev. This LGTM.

@adhiamboperes adhiamboperes enabled auto-merge (squash) October 14, 2023 13:00
@oppiabot oppiabot bot added the PR: LGTM label Oct 14, 2023
@oppiabot
Copy link

oppiabot bot commented Oct 14, 2023

Hi @Rd4dev, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes merged commit e060e2f into oppia:develop Oct 14, 2023
36 checks passed
@adhiamboperes adhiamboperes added the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhiamboperes adhiamboperes adhiamboperes approved these changes

Assignees

@Rd4dev Rd4dev

Labels
Hacktoberfest This is a suggested Hacktoberfest issue. PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All warnings in "Internationalization" and "Internationalization:Bidirectional Text" category
2 participants
@Rd4dev @adhiamboperes