Fix #5039 Terms of Service and Privacy Policy content should still be left-aligned, even if the app is in an RTL language.

[ShubhadeepKarmakar]

Explanation

• Fix [BUG]: Terms of Service and Privacy Policy content should still be left-aligned, even if the app is in an RTL language. #5039
  Under the ListItemLeadingMarginSpan class we have the ulSpan class and the olSpan class which takes displayLocal as an input and then retrieves the direction of the layout using the getLayoutDirection() method to get the bullet drawing position.
  That's why I created an object of the DisplayLocaleImp class and overridden the getLayoutDirection() method to pretend it's LTR.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)

Before:

rtl-problem.mp4

After:

rtl.mp4

Tablet view

Tablet View in landscape

[adhiamboperes]

Hey @ShubhadeepKarmakar , if this is ready for a review please assign it to me. Otherwise, please assign it to yourself.

YOu can run this command to fix your lint failures from terminal java -jar /home/runner/oppia-android-tools/ktlint -F --android domain/src/**/*.kt utility/src/**/*.kt data/src/**/*.kt app/src/**/*.kt testing/src/**/*.kt scripts/src/**/*.kt instrumentation/src/**/*.kt, and don't forget to add screenshots to the PR.

[adhiamboperes]

@ShubhadeepKarmakar is this ready to be reviewed?

[ShubhadeepKarmakar]

@ShubhadeepKarmakar is this ready to be reviewed?

Yeah.

[adhiamboperes]

Thanks @ShubhadeepKarmakar!

I was not able to understand the explanation you gave on the PR description, in relation to the problem and the solution. Could you please edit it and clarify?

Overall, I'm unsure of the approach, so I've brought it up with the team. I'll be able to review this further once that's resolved.

Meanwhile, please feel free to work on something else.

[oppiabot]

Unassigning @adhiamboperes since the review is done.

[oppiabot]

Hi @ShubhadeepKarmakar, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

[adhiamboperes]

Hi @ShubhadeepKarmakar, Could you PTAL at this feedback?

[oppiabot]

Hi @ShubhadeepKarmakar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[adhiamboperes]

@ShubhadeepKarmakar, are you still working on this PR?

[oppiabot]

Hi @ShubhadeepKarmakar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!