Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5133 Audio language name showing two times #5178

Closed
wants to merge 17 commits into from
Closed

Fix #5133 Audio language name showing two times #5178

wants to merge 17 commits into from

Conversation

Vishwajith-Shettigar
Copy link
Collaborator

@Vishwajith-Shettigar Vishwajith-Shettigar commented Oct 4, 2023 •
edited
Loading

Explanation

Fix #5133, filtered the language codes to display only the languages supported by Oppia.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Before fix
WhatsApp Image 2023-08-14 at 10 27 08 AM (1)
After fix
languageafetr

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@Vishwajith-Shettigar Vishwajith-Shettigar requested a review from a team as a code owner October 4, 2023 12:00
@Vishwajith-Shettigar
Copy link
Collaborator Author

@adhiamboperes , PTAL

adhiamboperes
adhiamboperes requested changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vishwajith-Shettigar!

  1. Could you please add before and after screenshots?
  2. We currently do not have tests for LanguageDialogFragment. Do you think you can explore adding one, and testing this fix? See: https://github.com/oppia/oppia-android/wiki/Oppia-Android-Testing

app/src/main/java/org/oppia/android/app/player/audio/AudioViewModel.kt Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Oct 4, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented Oct 4, 2023

Hi @Vishwajith-Shettigar, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@oppiabot
Copy link

oppiabot bot commented Oct 12, 2023

Hi @Vishwajith-Shettigar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 12, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 12, 2023
@oppiabot OppiaBot
Copy link

oppiabot bot commented Nov 15, 2023

Hi @Vishwajith-Shettigar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 15, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 15, 2023
@oppiabot OppiaBot
Copy link

oppiabot bot commented Nov 22, 2023

Hi @Vishwajith-Shettigar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 22, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 22, 2023
@adhiamboperes
Copy link
Collaborator

adhiamboperes commented Dec 4, 2023 •
edited
Loading

@Vishwajith-Shettigar, I'm closing this PR since the desired implementation is blocked. See #5133 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhiamboperes adhiamboperes adhiamboperes requested changes

Assignees

@Vishwajith-Shettigar Vishwajith-Shettigar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG][Blocked]: Audio language name showing two times
2 participants
@Vishwajith-Shettigar @adhiamboperes