-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3691: Adds Resume Lesson Tablet Portrait UI #5175
Fix #3691: Adds Resume Lesson Tablet Portrait UI #5175
Conversation
@adhiamboperes I have changed my GitHub username, so github-actions bot asks me to sign the CLA again. But I am unable to resubmit the CLA form because I have already submitted it once. |
@theMr17 that's okay, no worries, once you onboard this warning will goes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17! PTAL at the requested change.
app/src/main/res/layout-sw600dp-port/resume_lesson_fragment.xml
Outdated
Show resolved
Hide resolved
Unassigning @adhiamboperes since the review is done. |
Hi @theMr17, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
@adhiamboperes PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theMr17, you only missed one occurance, but otherwise LGTM.
app/src/main/res/layout-sw600dp-port/resume_lesson_fragment.xml
Outdated
Show resolved
Hide resolved
Unassigning @adhiamboperes since the review is done. |
Hi @theMr17, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, This LGTM.
Unassigning @adhiamboperes since they have already approved the PR. |
Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fixes #3691
Adds layout file for tablet portrait mode for resume lesson screen.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: