Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3691: Adds Resume Lesson Tablet Portrait UI #5175

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

theMr17
Copy link
Collaborator

@theMr17 theMr17 commented Oct 3, 2023

Explanation

Fixes #3691

Adds layout file for tablet portrait mode for resume lesson screen.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
Before After

@theMr17 theMr17 requested a review from a team as a code owner October 3, 2023 14:35
@theMr17 theMr17 requested a review from adhiamboperes October 3, 2023 14:35
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Hi! @theMr17 Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks!

@theMr17
Copy link
Collaborator Author

theMr17 commented Oct 4, 2023

@adhiamboperes I have changed my GitHub username, so github-actions bot asks me to sign the CLA again. But I am unable to resubmit the CLA form because I have already submitted it once.

@MohitGupta121
Copy link
Member

@theMr17 that's okay, no worries, once you onboard this warning will goes.

@adhiamboperes adhiamboperes self-assigned this Oct 5, 2023
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theMr17! PTAL at the requested change.

@oppiabot
Copy link

oppiabot bot commented Oct 6, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented Oct 6, 2023

Hi @theMr17, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@theMr17
Copy link
Collaborator Author

theMr17 commented Oct 6, 2023

@adhiamboperes PTAL.

@oppiabot oppiabot bot assigned adhiamboperes and unassigned theMr17 Oct 6, 2023
@oppiabot
Copy link

oppiabot bot commented Oct 6, 2023

Unassigning @theMr17 since a re-review was requested. @theMr17, please make sure you have addressed all review comments. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theMr17, you only missed one occurance, but otherwise LGTM.

@oppiabot
Copy link

oppiabot bot commented Oct 6, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented Oct 6, 2023

Hi @theMr17, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@theMr17 theMr17 requested a review from adhiamboperes October 6, 2023 17:17
@theMr17 theMr17 assigned adhiamboperes and unassigned theMr17 Oct 6, 2023
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, This LGTM.

@oppiabot
Copy link

oppiabot bot commented Oct 6, 2023

Unassigning @adhiamboperes since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Oct 6, 2023
@oppiabot
Copy link

oppiabot bot commented Oct 6, 2023

Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes enabled auto-merge (squash) October 6, 2023 18:28
@adhiamboperes adhiamboperes merged commit 783f8db into oppia:develop Oct 6, 2023
@adhiamboperes adhiamboperes added the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest This is a suggested Hacktoberfest issue. PR: LGTM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hi-fi Resume Lesson Tablet
3 participants