Fixes #2399: Reformatting required in dimension file for better structure #5168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aayushimathur6
changed the title
aayushimathur6
requested review from
adhiamboperes
and removed request for
adhiamboperes
|
@adhiamboperes PTAL, Thanks |
adhiamboperes
requested changes
Oct 3, 2023
There was a problem hiding this comment.
Thanks for organizing this file @aayushimathur6!
I propose that we keep the values categorized by screen name, and we don't have to break the screen dimens down into further categories because that will make the file more difficult to maintain.
|
Unassigning @adhiamboperes since the review is done. |
|
Hi @aayushimathur6, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
|
PTAL @adhiamboperes Thanks |
adhiamboperes
approved these changes
Oct 5, 2023
|
Unassigning @adhiamboperes since they have already approved the PR. |
|
Hi @aayushimathur6, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
adhiamboperes
pushed a commit
that referenced
this pull request
Dec 5, 2024
<!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation Fixes [#5168](#5186) 1. For `AppCompatCustomView`, replaced it with AppCompat Views 2. For `FragmentTagUsage`, replaced `<fragment/>` with <androidx.fragment.app.FragmentContainerView/>. Made some changes to `NavigationDrawerFragment` to: - ensured `setUpDrawer()` is called first to initialize the `drawerLayout`, `toolbar` and `menuItemId` - followed by `onCreateView()` ensuring to bind the fragment - followed on `onViewCreated()` to setup drawer functions/listeners 3. Faced an issue similar to [drawer not working](#5266), by minimising and resuming the app, (the drawer button stopped working). - Fixed this by removing `onRestart()` from respective Activies making a call to `setUpNavigationDrawer()` which at that point is not necessary, since the fragment has been inflated initially, and would be re-inflated if the fragment is recreated. 4. Also tested this [bug](#5284) following the steps to reproduce. No issues encountered **Lint report (Before):**  **Lint report (After):**  ## Screen Record https://github.com/user-attachments/assets/6db98657-d470-4263-a5ac-d055f4d64e66 ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #2399This PR has restructured the dimens.xml files. The file is too large so just rearranged the dimensions to form the groups on the base of their name, so that we find all the the dimensions related to a particular category at once with ease.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: