Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5170 [Feature Request]: Display some kind of loading animation/graphic when topics are loading in Home Page #5167

Merged
merged 18 commits into from
Oct 14, 2023

Conversation

Vishwajith-Shettigar
Copy link
Collaborator

@Vishwajith-Shettigar Vishwajith-Shettigar commented Sep 30, 2023

Explanation

Fix #5170. Added progressbar to the home fragment to show loading.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Light mode

WhatsApp.Video.2023-10-14.at.9.08.07.AM.mp4

Darkmode

WhatsApp.Video.2023-10-14.at.9.08.06.AM.mp4

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@adhiamboperes
Copy link
Collaborator

Closing this since the issue has been moved to design team.

@seanlip
Copy link
Member

seanlip commented Oct 1, 2023

@Vishwajith-Shettigar Out of interest, could you show a video of your proposed changes here?

@Vishwajith-Shettigar
Copy link
Collaborator Author

@Vishwajith-Shettigar Out of interest, could you show a video of your proposed changes here?

@seanlip I have attached screen recording in PR description

@seanlip
Copy link
Member

seanlip commented Oct 1, 2023

Thanks @Vishwajith-Shettigar. Actually, this seems quite a reasonable interim fix, so I'm reopening this PR.

@adhiamboperes Feel free to accept this if you feel that it looks good from a technical perspective. It looks fine to me from the PM side. Thanks!

@seanlip seanlip reopened this Oct 1, 2023
@adhiamboperes
Copy link
Collaborator

@Vishwajith-Shettigar this should be reasonably completed if you add tests for the progressbar being shown and hidden as intended, and also demonstrate that it displays with the correct colors in light mode.

@Vishwajith-Shettigar Vishwajith-Shettigar marked this pull request as ready for review October 12, 2023 05:39
@Vishwajith-Shettigar Vishwajith-Shettigar requested a review from a team as a code owner October 12, 2023 05:39
@Vishwajith-Shettigar Vishwajith-Shettigar changed the title added progress bar to home fragment Fix #5170 [Feature Request]: Display some kind of loading animation/graphic when topics are loading in Home Page Oct 12, 2023
@Vishwajith-Shettigar
Copy link
Collaborator Author

@adhiamboperes, PTAL

@Vishwajith-Shettigar Vishwajith-Shettigar self-assigned this Oct 13, 2023
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vishwajith-Shettigar!

From your videos, I noticed that the progressbar is blue in color. The color should be green, and it should be defined per oppia color guidelines for darkmode support. The correct color to use here is @color/color_def_oppia_green

@oppiabot
Copy link

oppiabot bot commented Oct 13, 2023

Unassigning @adhiamboperes since the review is done.

@Vishwajith-Shettigar
Copy link
Collaborator Author

Thanks @Vishwajith-Shettigar!

From your videos, I noticed that the progressbar is blue in color. The color should be green, and it should be defined per oppia color guidelines for darkmode support. The correct color to use here is @color/color_def_oppia_green

I made changes, PTAL

@oppiabot
Copy link

oppiabot bot commented Oct 14, 2023

Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vishwajith-Shettigar! This LGTM.

@adhiamboperes adhiamboperes merged commit 1496445 into oppia:develop Oct 14, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Display some kind of loading animation/graphic when topics are loading in Home Page
3 participants