-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5170 [Feature Request]: Display some kind of loading animation/graphic when topics are loading in Home Page #5167
Fix #5170 [Feature Request]: Display some kind of loading animation/graphic when topics are loading in Home Page #5167
Conversation
Closing this since the issue has been moved to design team. |
@Vishwajith-Shettigar Out of interest, could you show a video of your proposed changes here? |
@seanlip I have attached screen recording in PR description |
Thanks @Vishwajith-Shettigar. Actually, this seems quite a reasonable interim fix, so I'm reopening this PR. @adhiamboperes Feel free to accept this if you feel that it looks good from a technical perspective. It looks fine to me from the PM side. Thanks! |
@Vishwajith-Shettigar this should be reasonably completed if you add tests for the progressbar being shown and hidden as intended, and also demonstrate that it displays with the correct colors in light mode. |
@adhiamboperes, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Vishwajith-Shettigar!
From your videos, I noticed that the progressbar is blue in color. The color should be green, and it should be defined per oppia color guidelines for darkmode support. The correct color to use here is @color/color_def_oppia_green
Unassigning @adhiamboperes since the review is done. |
I made changes, PTAL |
Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Vishwajith-Shettigar! This LGTM.
Explanation
Fix #5170. Added progressbar to the home fragment to show loading.
Essential Checklist
For UI-specific PRs only
Light mode
WhatsApp.Video.2023-10-14.at.9.08.07.AM.mp4
Darkmode
WhatsApp.Video.2023-10-14.at.9.08.06.AM.mp4
If your PR includes UI-related changes, then: