Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5164 Format strings.xml(values-en) so that string tags are on one line #5166

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

Vishwajith-Shettigar
Copy link
Collaborator

@Vishwajith-Shettigar Vishwajith-Shettigar commented Sep 30, 2023

Explanation

Fix #5164 , format the strings.xml(values-en).
Because some strings are multiline, they are parsed with newlines on translatewiki which cascades down to the translated strings. This causes a problem with display. So formatted them to single line

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@Vishwajith-Shettigar
Copy link
Collaborator Author

@adhiamboperes, PTAL

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vishwajith-Shettigar, this LGTM.

Can you update your PR description with an explanation of the changes being made and why? Please refer to the issue description for this.

@oppiabot
Copy link

oppiabot bot commented Oct 1, 2023

Unassigning @adhiamboperes since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Oct 1, 2023
@oppiabot
Copy link

oppiabot bot commented Oct 1, 2023

Hi @Vishwajith-Shettigar, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@Vishwajith-Shettigar
Copy link
Collaborator Author

Thanks @Vishwajith-Shettigar, this LGTM.

Can you update your PR description with an explanation of the changes being made and why? Please refer to the issue description for this.

@adhiamboperes I have updated PR description

@adhiamboperes adhiamboperes merged commit 590ecdf into oppia:develop Oct 1, 2023
36 checks passed
@adhiamboperes adhiamboperes added the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest This is a suggested Hacktoberfest issue. PR: LGTM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Format strings.xml(values-en) so that string tags are on one line
2 participants