-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localisation updates from https://translatewiki.net. #5161
Conversation
b489586
to
123b6ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<string name="ratio_error_invalid_chars">\n Escreva uma proporção que consista em dígitos separados por dois pontos (por exemplo, 1:2 ou 1:2:3).\n \\</string> | ||
<string name="ratio_error_invalid_format">\n Insira uma proporção válida (por exemplo, 1:2 ou 1:2:3).\n \\</string> | ||
<string name="ratio_error_invalid_colons">Sua resposta tem dois dois-pontos (:) do lado um do outro.</string> | ||
<string name="ratio_error_invalid_size">O número de termos não é igual ao exigido.</string> | ||
<string name="ratio_error_includes_zero">Proporções não podem ter 0 como elemento.</string> | ||
<string name="ratio_error_invalid_size">\n O número de termos não é igual ao exigido.\n \\</string> | ||
<string name="ratio_error_includes_zero">\n Proporções não podem ter 0 como elemento.\n \\</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid newlinesand escape characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just fixed these directly on translatewiki.
One note: it seems that the English strings might be causing confusion because there's a newline after the opening tag and below the closing tag (ref). This results in them looking like this in translatewiki (notice the indent at the start and the line break at the end):
@adhiamboperes Would it be possible to update the original file to have each <string></string>
tag in a single line perhaps (and maybe add a lint check to enforce this)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanlip, I checked, we can update all these string values to be on one line. Plurals and quantities are however usually formatted as multiline in the strings files, but each of their <item>
tags should also be on one line. Great catch!
<string name="ratio_content_description_separator">\n para\n \\</string> | ||
<string name="ratio_default_hint_text">\n Insira uma razão no formato x:y.\n \\</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid newlines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed directly on translatewiki
<item quantity="one">1 história concluída\n </item> | ||
<item quantity="zero">%s Histórias concluídas\n </item> | ||
<item quantity="other">\n %s Histórias concluídas\n </item> | ||
</plurals> | ||
<plurals name="ongoing_topic_count"> | ||
<item quantity="one">1 Tópico em Andamento\n </item> | ||
<item quantity="zero">%s Tópicos em Andamento\n </item> | ||
<item quantity="other">\n %s Tópicos em Andamento\n </item> | ||
<item quantity="one">1 Tópico em andamento\n </item> | ||
<item quantity="zero">%s Tópicos em andamento\n </item> | ||
<item quantity="other">\n %s Tópicos em andamento\n </item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid new lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @translatewiki, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adhiamboperes, I went ahead and fixed the issues directly on translatewiki. They should hopefully be updated in the next push; we could close this PR in the meanwhile if you like.
That said, you might want to take a look at the comments and either fix them or file issues, since I think the existing English strings.xml file is what's causing the confusion here. (See inline comments for details.) Thanks!
<string name="ratio_error_invalid_chars">\n Escreva uma proporção que consista em dígitos separados por dois pontos (por exemplo, 1:2 ou 1:2:3).\n \\</string> | ||
<string name="ratio_error_invalid_format">\n Insira uma proporção válida (por exemplo, 1:2 ou 1:2:3).\n \\</string> | ||
<string name="ratio_error_invalid_colons">Sua resposta tem dois dois-pontos (:) do lado um do outro.</string> | ||
<string name="ratio_error_invalid_size">O número de termos não é igual ao exigido.</string> | ||
<string name="ratio_error_includes_zero">Proporções não podem ter 0 como elemento.</string> | ||
<string name="ratio_error_invalid_size">\n O número de termos não é igual ao exigido.\n \\</string> | ||
<string name="ratio_error_includes_zero">\n Proporções não podem ter 0 como elemento.\n \\</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just fixed these directly on translatewiki.
One note: it seems that the English strings might be causing confusion because there's a newline after the opening tag and below the closing tag (ref). This results in them looking like this in translatewiki (notice the indent at the start and the line break at the end):
@adhiamboperes Would it be possible to update the original file to have each <string></string>
tag in a single line perhaps (and maybe add a lint check to enforce this)?
<item quantity="one">1 história concluída\n </item> | ||
<item quantity="zero">%s Histórias concluídas\n </item> | ||
<item quantity="other">\n %s Histórias concluídas\n </item> | ||
</plurals> | ||
<plurals name="ongoing_topic_count"> | ||
<item quantity="one">1 Tópico em Andamento\n </item> | ||
<item quantity="zero">%s Tópicos em Andamento\n </item> | ||
<item quantity="other">\n %s Tópicos em Andamento\n </item> | ||
<item quantity="one">1 Tópico em andamento\n </item> | ||
<item quantity="zero">%s Tópicos em andamento\n </item> | ||
<item quantity="other">\n %s Tópicos em andamento\n </item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<string name="ratio_content_description_separator">\n para\n \\</string> | ||
<string name="ratio_default_hint_text">\n Insira uma razão no formato x:y.\n \\</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed directly on translatewiki
Hi @translatewiki, it looks like some changes were requested on this pull request by @seanlip. PTAL. Thanks! |
|
Translation updates