FIX #2652 Splash Screen Stretched #5147
Conversation
|
Hi! @backpackerdeveloper Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks! |
|
Signed the CLA sheet 👍 |
There was a problem hiding this comment.
Hey @backpackerdeveloper, can you tell me about any alternative solutions you considered before adding the sdp lib?
Please also read the wiki on submitting a PR. You deleted the PR template but you need to fill it out instead. Please look at #5148 other PRs in the repo and copy the PR description template and add it to this PR.
backpackerdeveloper
changed the title
|
@adhiamboperes As I saw ConstraintLayout is properly, assigned, so I directly sdp lib, and it worked. |
There was a problem hiding this comment.
Hi @backpackerdeveloper, thanks for this PR. There are a number of things that need work in order for us to accept this solution:
- The library needs to be added to bazel as well as gradle. Please follow this wiki to add a dependency to bazel.
- We do not need to update gradle now, so please exclude any gradle wrapper update changes from your PR.
- Please refer to the wiki on submitting a PR. Your branch is called develop, and that is prohibited in the repo.
- Add before and after screenshots to your PR, to demostrate the changes.(Also make sure you read the essential checklist because it has important requirements)
This means that you should close this PR and open a new one with an appropriately named branch, and also please address all these comments in the new PR.
There was a problem hiding this comment.
This should not be part of the commit.
There was a problem hiding this comment.
Please remove this change, we do not want to update gradle at the moment.
|
Unassigning @adhiamboperes since the review is done. |
|
Hi @backpackerdeveloper, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
FIX #2652 Splash Screen Stretched
Changes:
ABOUT SDP
An android lib that provides a new size unit - sdp (scalable dp). This size unit scales with the screen size. It can help with supporting multiple screens.