Fix #4803 Failed to add Admin (or non-admin) Profile Picture.

[ShubhadeepKarmakar]

Explanation

• Fix Failed to add Admin (or non-admin) Profile Picture. #4803
  val galleryIntent = Intent(Intent.ACTION_PICK, MediaStore.Images.Media.EXTERNAL_CONTENT_URI)
  The above code (previous) is the explicit way to get images from gallery but is not working here. But the updated code below is less explicit but works fine,
  val galleryIntent = Intent(Intent.ACTION_GET_CONTENT).apply { type = "image/*" }

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

Screen Recording

oppia.mp4

[adhiamboperes]

Thanks @ShubhadeepKarmakar!

Hi @kkmurerwa, could you give this a pass and assign it to me once any initial concerns have been addressed?

[adhiamboperes]

Thanks @ShubhadeepKarmakar!

In addition to the tests, please update the following so that we can merge your PR:

1. Your PR title should either describe the problem being solved, or make it the same as the issue title.
2. Instead of saying "Added two lines to the codebase and resolved.", please explain the change you have made in terms of why the old code didn't work, and why your change fixes the bug. This is helpful for future developers reading the code.

[adhiamboperes]

Additionally, here is a link to the wiki to help you identify the cause of your failing CI checks, and another link to fixing static analysis check failures.

[oppiabot]

Hi @ShubhadeepKarmakar, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

[kkmurerwa]

Hi @adhiamboperes. I see that you have already done a review of this PR. I don't think I have any further comments. @ShubhadeepKarmakar if you get stuck, feel free to reach out to me.

[ShubhadeepKarmakar]

@kkmurerwa I am facing this problem at the time of updating the test cases

[kkmurerwa]

@kkmurerwa I am facing this problem at the time of updating the test cases

Hi @ShubhadeepKarmakar. The problem could be the Android Studio version that you are using. Please check that you are using Android Studio Bumblebee.

[ShubhadeepKarmakar]

@kkmurerwa I am facing this problem at the time of updating the test cases

Hi @ShubhadeepKarmakar. The problem could be the Android Studio version that you are using. Please check that you are using Android Studio Bumblebee.

I'm currently using Android Studio Electric Eel,
Oky, lets see what happen after dropping the version.

[ShubhadeepKarmakar]

I'm facing an installation error while running the test testProfileProgressFragment_imageSelectAvatar_configChange_checkGalleryIntent

[adhiamboperes]

I'm facing an installation error while running the test testProfileProgressFragment_imageSelectAvatar_configChange_checkGalleryIntent

My experience with Xiaomi devices is that you need to accept the install permission request. It's best to use the "remember my choice" option.

An alternative is to setup an Android emulator. Preferably pixel 3a sdk 29.

Could you also take another look at the wiki set up instructions for additional information?

[adhiamboperes]

Thanks!

I just had one more comment, but otherwise your changes look good so far.

[adhiamboperes]

Thanks @ShubhadeepKarmakar!

Congratulations on getting your first PR approveed! Your changes LGTM.

[oppiabot]

Hi @ShubhadeepKarmakar, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!