Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3772: Add ci check for style check for text views #4128

Conversation

yash10019coder
Copy link
Contributor

@yash10019coder yash10019coder commented Jan 23, 2022

Explanation

Fixes #3972

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@oppiabot
Copy link

oppiabot bot commented Feb 19, 2022

Hi @yash10019coder, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 19, 2022
@oppiabot oppiabot bot closed this Feb 26, 2022
@yash10019coder yash10019coder reopened this Mar 4, 2022
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 4, 2022
@yash10019coder
Copy link
Contributor Author

Hi @BenHenning currently I have created a script for RTL support but it does not have checkpointing for the specific file and line in which error is detected can you please provide me some hint how to implement it thanks

@oppiabot
Copy link

oppiabot bot commented Mar 23, 2022

Hi @yash10019coder, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 23, 2022
@BenHenning
Copy link
Member

BenHenning commented Mar 24, 2022

Hi @BenHenning currently I have created a script for RTL support but it does not have checkpointing for the specific file and line in which error is detected can you please provide me some hint how to implement it thanks

@yash10019coder you'll need to do research on the APIs in question to see how you can retrieve and/or track the line number. After a few-minute search, it looks like the SAX parser supports providing a Locator which can be used to track line numbers. I think there are several Stackoverflow answers for this topic that can give you an idea of how to solve it (though please don't just copy the code snippets--we should make sure solutions are written from scratch with SO only being used as a reference, not a code source).

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 24, 2022
@oppiabot
Copy link

oppiabot bot commented Mar 31, 2022

Hi @yash10019coder, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 31, 2022
@oppiabot oppiabot bot closed this Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Corresponds to items that haven't seen a recent update and may be automatically closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI check to ensure all TextViews have a style check
2 participants