Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1873: Fix OnboardingFragmentTest test cases on Robolectric #2482

Merged
merged 60 commits into from
Feb 3, 2021
Merged

Fix #1873: Fix OnboardingFragmentTest test cases on Robolectric #2482

Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
df75643
fixed one test
prayutsu Oct 1, 2020
af2fb52
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
prayutsu Oct 4, 2020
a87d960
fix 4 remaining tests
prayutsu Oct 5, 2020
a23aea0
try fixing tests bu introducing scrollview
prayutsu Oct 8, 2020
b498b4d
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
prayutsu Oct 8, 2020
4d46313
tried adding scrollview
prayutsu Oct 8, 2020
be8405b
fix AndroidManifest.xml
prayutsu Oct 8, 2020
564d1bd
fix nit
prayutsu Oct 8, 2020
1e34fa2
fix basic set of tests
prayutsu Oct 9, 2020
7e2fbb6
fixed 3 failing tests
prayutsu Oct 10, 2020
eabd915
removed extra changes
prayutsu Oct 10, 2020
11a9b61
removed extra changes
prayutsu Oct 10, 2020
543d34c
try fixing tests with testCoroutineDispatchers
prayutsu Oct 13, 2020
da4f678
try advancedUntilIdle()
prayutsu Oct 24, 2020
6b7b059
tried migrating to viewpager2
prayutsu Oct 30, 2020
e028aa9
tried implementing new methods
prayutsu Nov 3, 2020
12540d3
Replace ViewPager with ViewPager2
prayutsu Nov 18, 2020
db59608
Add ignore annotations
prayutsu Nov 18, 2020
708a488
fix lint
prayutsu Nov 18, 2020
75eac88
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
prayutsu Nov 18, 2020
250530b
add dependencies to BUILD.bazel
prayutsu Nov 18, 2020
8929252
remove unnecessary ignore annotations
prayutsu Nov 18, 2020
176dec4
fix tests by using swipeLeft and swiperight
prayutsu Dec 2, 2020
8cc353f
fix lint
prayutsu Dec 3, 2020
6555129
fix lint
prayutsu Dec 3, 2020
811e772
fix lint
prayutsu Dec 3, 2020
5d92e0c
fix lint error
prayutsu Dec 3, 2020
f8ce120
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
prayutsu Dec 7, 2020
06a7a71
remove redundant lines
prayutsu Dec 9, 2020
4a39e40
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
prayutsu Jan 15, 2021
bf0b6b7
Fix Viewpager2 regressions
prayutsu Jan 15, 2021
3f5fff8
Fix lint errors.
prayutsu Jan 15, 2021
9a3d39c
Remove comments
prayutsu Jan 15, 2021
940137c
Fix all test cases on Robolectric
prayutsu Jan 15, 2021
2151c45
Try fixing flakiness in espresso
prayutsu Jan 15, 2021
709c7c8
Revert "Try fixing flakiness in espresso"
prayutsu Jan 15, 2021
6976d7d
Replace isDisplayed() with isCompletelyDisplayed()
prayutsu Jan 18, 2021
54a4659
Fix suggested changes
prayutsu Jan 20, 2021
9840c22
Try fixing test cases by using isADescendantOf()
prayutsu Jan 20, 2021
950401c
Revert changes
prayutsu Jan 20, 2021
2db7622
Try stabilizing ttion est cases by changing configuration
prayutsu Jan 21, 2021
5a8a8cd
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
prayutsu Jan 21, 2021
3b8e1fb
Revert last commit to remove unwanted configuration changes
prayutsu Jan 26, 2021
7f02b77
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
prayutsu Jan 26, 2021
8903b00
Fix ktlint error
prayutsu Jan 26, 2021
4c33d03
Resolve merge conflicts
prayutsu Jan 28, 2021
f9cd0e5
Try adding custom ViewMatcher
prayutsu Jan 29, 2021
5413965
Add custom ViewMatcher
prayutsu Jan 29, 2021
4f2fff8
Add custom ViewAction for scrolling ViewPager pages
prayutsu Jan 29, 2021
c1786e5
Disable smooth scrolling to fix test cases
prayutsu Jan 29, 2021
dd21e64
Remove holder.setIsRecycleable(false) and optimise perform()
prayutsu Jan 29, 2021
83f14db
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
prayutsu Jan 29, 2021
b7a671f
Remove unnecessary id of constraintLayout in onboarding_slide.xml
prayutsu Jan 29, 2021
ca84aea
Replace advancedUntilIdle bu runCurrent wherever applicable
prayutsu Jan 29, 2021
3555545
Remove unnecessary delay
prayutsu Jan 29, 2021
98a4db2
Add argument comment for smoothScroll
prayutsu Jan 30, 2021
26fb177
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
prayutsu Feb 2, 2021
3023508
Add a space after argument comment
prayutsu Feb 2, 2021
33a48da
Fix suggested changes.
prayutsu Feb 3, 2021
1ee0cf5
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
prayutsu Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/sharedTest/java/org/oppia/android/app/onboarding/OnboardingFragmentTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ class OnboardingFragmentTest {
}

override fun perform(uiController: UiController?, view: View?) {
(view as ViewPager2).setCurrentItem(position, false)
(view as ViewPager2).setCurrentItem(position, /* smoothScroll= */false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(view as ViewPager2).setCurrentItem(position, /* smoothScroll= */false)
(view as ViewPager2).setCurrentItem(position, /* smoothScroll= */ false)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}
}
}
Expand Down