Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1042 Status bar color for pre-lollipop versions #1086

Closed

Conversation

prathameshbhalekar
Copy link

@prathameshbhalekar prathameshbhalekar commented May 19, 2020

Explanation

Fixes #1042. I have made changes to the util.statusbarcolor file. I have also added a view in xml files of fragments which required changes. I have also added passed the view in the chengestatubarcolor method in the presenters of above mentioned fragments. I inspected the code with android studio and the rest are the changes from that process. .

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@prathameshbhalekar
Copy link
Author

@nikitamarysolomanpvt I created new pull request. Can you please check it out?

@aggarwalpulkit596
Copy link
Contributor

aggarwalpulkit596 commented May 20, 2020

@mschanteltc sure go ahead.

@mschanteltc
Copy link

@mschanteltc sure go ahead.

Is this tag meant for me?

@rt4914
Copy link
Contributor

rt4914 commented May 26, 2020

@mschanteltc sure go ahead.

Is this tag meant for me?

@mschanteltc There is some mistake. As I don't see any particular question directed to you. So. i think you can avoid this. Thanks.

@nikitamarysolomanpvt
Copy link
Contributor

@nikitamarysolomanpvt I created new pull request. Can you please check it out?

@prathameshbhalekar Could you please put the screenshots with the device specifications that you used for testing. When i checked it is not working properly.

@rt4914
Copy link
Contributor

rt4914 commented Jun 12, 2020

Closing this PR as there has been no updates on this PR from contributor.

@rt4914 rt4914 closed this Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status bar color fix for pre-lollipop versions
5 participants