Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI check to ensure all TextViews have a style check #3972

Open
BenHenning opened this issue Oct 26, 2021 · 7 comments · May be fixed by #5599
Open

Add CI check to ensure all TextViews have a style check #3972

BenHenning opened this issue Oct 26, 2021 · 7 comments · May be fixed by #5599
Assignees
@manas-yu
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

Related issue: #3971. We need to make sure that TextViews have a centrally managed style set so that RTL/LTR settings can be properly managed. To do this, we need a CI check that runs a script which parses all layout files to ensure that TextView elements have a style set that corresponds to a local codebase style (i.e. uses @style/).

For reference, I suggest looking at the manifest transformation script since it parses & modifies XML today (so it's a good basis for the parsing needs of this new TextView script).
@BenHenning
Copy link
Member Author

/cc @veena14cs

@yash10019coder
Copy link
Contributor

@BenHenning I would like to work on this issue

@BenHenning
Copy link
Member Author

BenHenning commented Jan 5, 2022 •
edited
Loading

@BenHenning I would like to work on this issue

Sounds good! Assigning this to you @yash10019coder.

@yash10019coder yash10019coder mentioned this issue Jan 23, 2022
Closed
6 tasks
@Broppia Broppia added the Impact: Low Low perceived user impact (e.g. edge cases). label Jun 13, 2022
@BenHenning BenHenning added Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_type_infrastructure labels Mar 28, 2023
@MohitGupta121 MohitGupta121 added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Jun 16, 2023
@adhiamboperes adhiamboperes added the good first issue This item is good for new contributors to make their pull request. label Mar 26, 2024
@Rd4dev Rd4dev self-assigned this Apr 12, 2024
@Rd4dev
Copy link
Collaborator

Rd4dev commented Jul 23, 2024

Unassigning myself to free it up for others. Will pick it up later if it's still available.

@Rd4dev Rd4dev removed their assignment Jul 23, 2024
@manas-yu
Copy link
Collaborator

manas-yu commented Dec 6, 2024

HI @adhiamboperes can i work on this issue, i'll add the requested TextViewStyleChecker script.

@adhiamboperes
Copy link
Collaborator

@manas-yu, could you please provide an outline of how you would approach this issue?

@manas-yu
Copy link
Collaborator

manas-yu commented Dec 10, 2024 •
edited
Loading

@manas-yu, could you please provide an outline of how you would approach this issue?

@adhiamboperes I'll add the TextViewStyleChecker in scripts/xml, using TransformAndroidManifest/XmlSyntaxCheck.kt as a reference. The script will verify whether TextView elements are missing the @style attribute. I'll update the BUILD.bazel file to include this new script and add corresponding tests to ensure it works as expected.

@manas-yu manas-yu self-assigned this Dec 10, 2024
@manas-yu manas-yu mentioned this issue Dec 11, 2024
Merged
6 tasks
@manas-yu manas-yu linked a pull request Dec 16, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manas-yu manas-yu

Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Status: In Progress
Milestone
No milestone
8 participants
@seanlip @BenHenning @adhiamboperes @yash10019coder @MohitGupta121 @Broppia @manas-yu @Rd4dev