-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Terms of Service and Privacy Policy content should still be left-aligned, even if the app is in an RTL language. #5039
Comments
Same thing is happening on the onboardimg screen.onboarding.screen.mp4 |
I would like to work on this issue. |
What's your proposal for fixing this? |
ltr.mp4
These changes are made in the PoliciesFragmentPresenter.kt class and work perfectly but this is not the correct approach I think. DisplayLocaleImpl.kt class was final in nature but I had to make the DisplayLocaleImpl class open in nature to change the PoliciesFragmentPresenter class. |
I get the sense that you are trying to force the layout direction to be LTR. You don't need to modify DisplayLocaleImpl or override it's methods to retrieve Layout Direction. AppLanguageResourceHandler has a public api for that, |
Under the ListItemLeadingMarginSpan class we have the ulSpan class and the olSpan class which takes displayLocal as an input and then retrieves the direction of the layout using the getLayoutDirection() method to get the bullet drawing position. @adhiamboperes any suggestion? |
The layout direction retrieved will be the same regardless of the function you call to retrieve it, which is why you should use the public function from AppLanguageResourceHandler and don't reimplement DisplayLocale. |
is this issue fixed? |
@neeldoshii, feel free to suggest a fix for this. Please also refer to #5181 (comment) for a potential solution. |
Sure @adhiamboperes, I will release a fix in my PR based on the comment. |
At the moment, Our discussions page is the best place to communicate. |
@Vishwajith-Shettigar I am still working on this. If you don't mind can I work on it? |
Hi @adhiamboperes, currently on the debug release we are not able to change the app language? Is it some kind of issue? |
Hi @neeldoshii if you are working on any issue you should be assigned first, please take care of it, I'm closing my PR and assigning you. |
You are using gradle to build i guess, if you want change app language you have to build app on bazel and for this issue you can change your system language to arabic or something like that. |
@neeldoshii, as @Vishwajith-Shettigar said, you can instead change your system language to RTL like Arabic which will also change the app language, if you're unable to build bazel. |
I have worked and able to make the text to have in LTR.
I have followed the instructions based on the mentioned. I am little confused. If you look closely html Any idea how to solve this? @adhiamboperes @Vishwajith-Shettigar |
@neeldoshii I doubt that texts are still in proper LTR mode according to the screenshot ( look at last sentence of all paragraphs). Better you create a draft PR. For |
@TanishMoral11, could you work on this issue? |
Hey @adhiamboperes, |
Describe the bug
In RTL languages, we are currently keeping our Terms of Service and Privacy policy content in English (so that we can have a canonical version). However, the English text should be left-aligned.
(Thanks to @KolliAnitha for the repro and images, which I took from #5028.)
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The English content should be left-aligned (but not the note at the bottom of the page linking to the up-to-date policy).
Demonstration
Environment
Device/emulator being used: Infinix SMART 5
Android or SDK version (e.g. Android 5 or SDK 21): Android 11
App version (you can get this through system app settings or via the admin controls menu in-app): 0.11-beta-8c81c98d8b
The text was updated successfully, but these errors were encountered: