Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Glide drawable native crash on KitKat #3887

Closed
BenHenning opened this issue Oct 6, 2021 · 5 comments · Fixed by #5018
Closed

Investigate Glide drawable native crash on KitKat #3887

BenHenning opened this issue Oct 6, 2021 · 5 comments · Fixed by #5018
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

After a forthcoming PR is merged to introduce basic KitKat support, there'a fairly common crash that occurs (especially on fresh install) on KitKat devices after opening the home screen. This seems to correlate to vector drawables that are loaded & transformed directly by Glide. It's not exactly clear what might be causing this crash, but it's expected to necessary to fix to unblock KitKat launch.

Further, this may not actually be a true problem in practice since we don't rely on the drawable mechanism for production since all thumbnails are loaded. This issue should investigate whether removing the drawable pipeline for thumbnails fixes the issue, and whether the other Glide transformation pipelines have the same crash potential.
@BenHenning BenHenning changed the title Investigate Glide drawable crashes on KitKat Investigate Glide drawable native crashes on KitKat Oct 6, 2021
@BenHenning BenHenning changed the title Investigate Glide drawable native crashes on KitKat Investigate Glide drawable native crash on KitKat Oct 6, 2021
@BenHenning
Copy link
Member Author

bumptech/glide#372 (comment) is a similar crash to what I saw.

@BenHenning BenHenning mentioned this issue Oct 7, 2021
Merged
6 tasks
@BenHenning BenHenning mentioned this issue Oct 21, 2021
Closed
@BenHenning
Copy link
Member Author

BenHenning commented Oct 21, 2021 •
edited
Loading

Note: per #3939 this is also observed as happening on occasional reopens (sometimes consistently back-to-back).

That issue also includes a native trace that might be helpful in debugging or at least providing a bit more context.

@BenHenning BenHenning mentioned this issue Oct 21, 2021
Closed
@BenHenning
Copy link
Member Author

For searching context, this issue was found in 0.6-alpha (MR3).

@Broppia Broppia added issue_type_bug Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Jul 7, 2022
@BenHenning BenHenning added Impact: Low Low perceived user impact (e.g. edge cases). TODO: need task force Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). TODO: need task force labels Sep 15, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_user_learner labels Mar 29, 2023
@seanlip
Copy link
Member

seanlip commented Jun 4, 2023

Per #5012, we are deprecating support for Android KitKat, so this issue is no longer valid.

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2023
@github-actions github-actions bot reopened this Jun 4, 2023
@github-actions
Copy link

github-actions bot commented Jun 4, 2023

The issue is reopened because of the following unresolved TODOs:

oppia-android/utility/src/main/java/org/oppia/android/util/parser/image/GlideImageLoader.kt

Line 68 in 81a95b7

// TODO(#3887): Investigate why this has a native crash on KitKat & find a fix.

seanlip added a commit that referenced this issue Jun 5, 2023
@seanlip
Fix #3886 and #3887: drop remaining KitKat TODOs.
2d60ca5
@seanlip seanlip mentioned this issue Jun 5, 2023
Merged
6 tasks
adhiamboperes pushed a commit that referenced this issue Jun 5, 2023
@seanlip
Fix #3886 and #3887: drop remaining KitKat TODOs. (#5018)
f727c06 
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
This PR fixes #3886 and fixes #3887 by dropping TODOs for those obsolete
issues so that they can be fully closed.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [ ] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3886 and #3887: drop remaining KitKat TODOs. oppia/oppia-android
3 participants
@seanlip @BenHenning @Broppia