Skip to content

Commit

Permalink
Fix #3886 and #3887: drop remaining KitKat TODOs. (#5018)
Browse files Browse the repository at this point in the history
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
This PR fixes #3886 and fixes #3887 by dropping TODOs for those obsolete
issues so that they can be fully closed.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [ ] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
  • Loading branch information
seanlip authored Jun 5, 2023
1 parent 85a9f24 commit f727c06
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion build_flavors.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ _FLAVOR_METADATA = {
"target_sdk_version": 31,
"multidex": "manual_main_dex",
"main_dex_list": _MAIN_DEX_LIST_TARGET_KITKAT,
"proguard_specs": [], # TODO(#3886): Re-add Proguard support to alpha_kitkat.
"proguard_specs": [],
"production_release": True,
"deps": [
"//app/src/main/java/org/oppia/android/app/application/alpha:alpha_application",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ class GlideImageLoader @Inject constructor(
target: ImageTarget<Drawable>,
transformations: List<ImageTransformation>
) {
// TODO(#3887): Investigate why this has a native crash on KitKat & find a fix.
glide
.asDrawable()
.load(imageDrawableResId)
Expand Down

0 comments on commit f727c06

Please sign in to comment.