Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status bar color fix for pre-lollipop versions #1042

Closed
rt4914 opened this issue May 6, 2020 · 18 comments
Closed

Status bar color fix for pre-lollipop versions #1042

rt4914 opened this issue May 6, 2020 · 18 comments
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented May 6, 2020

Reference: https://stackoverflow.com/questions/22192291/how-to-change-the-status-bar-color-in-android/26215844#26215844

The status bar color in various android screens is inconsistent. Update status bar color code as per the mocks and spreadsheet:
https://docs.google.com/spreadsheets/d/1XphP6nWoUdOZn9pY2kdgfqMWfJjMfKMb98MXM5rp2HY/edit#gid=0
https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/

Comment Reference: #1023 (comment)
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Workstream: Highfi UI labels May 6, 2020
@prathameshbhalekar
Copy link

Can I work on this issue? I might need some help as I have never contributed before.

@rt4914
Copy link
Contributor Author

rt4914 commented May 12, 2020

Can I work on this issue? I might need some help as I have never contributed before.

@prathameshbhalekar You can work on this.

@prathameshbhalekar
Copy link

@rt4914 thank you very much. Can I contact you in case I need any help?

@nikitamarysolomanpvt
Copy link
Contributor

nikitamarysolomanpvt commented May 15, 2020 •
edited
Loading

@rt4914 thank you very much. Can I contact you in case I need any help?

@prathameshbhalekar #1023 (comment) contains one of the solutions and you also mentioned it in your document attached in the mail. Please do communicate here, also please do create the PR for the same.

prathameshbhalekar added a commit to prathameshbhalekar/oppia-android that referenced this issue May 18, 2020
@prathameshbhalekar
Status bar color fix for pre-lollipop versions oppia#1042
92d1ef7
prathameshbhalekar added a commit to prathameshbhalekar/oppia-android that referenced this issue May 18, 2020
@prathameshbhalekar
Status bar color fix for pre-lollipop versions oppia#1042
344d228
prathameshbhalekar added a commit to prathameshbhalekar/oppia-android that referenced this issue May 18, 2020
@prathameshbhalekar
Status bar color fix for pre-lollipop versions oppia#1042
85a8c38
@prathameshbhalekar prathameshbhalekar mentioned this issue May 19, 2020
Closed
8 tasks
@BenHenning BenHenning added this to the Beta milestone Jun 23, 2020
@Arjupta
Copy link
Contributor

Arjupta commented Sep 30, 2020

@rt4914 Sir this issue is not assigned to anyone, Can I work on it?
I saw the commits of the previously assigned contributor, in his PR there was a mention that this method suggested by stack overflow is not working. If I start working on it so shall I look for another method or this one only.

@rt4914
Copy link
Contributor Author

rt4914 commented Sep 30, 2020

@Arjupta Thanks for going through the previous PR. I suggest trying out your own approach while keeping that previous PR in mind.

@aggarwalpulkit596 Thanks for helping out.

@rt4914
Copy link
Contributor Author

rt4914 commented Sep 30, 2020

Also, @Arjupta I suggest you also work on one more issue from https://github.com/oppia/oppia-android/issues?page=1&q=is%3Aopen+is%3Aissue+label%3A%22SLoP+2020%22
Considering this issue solving might take some time. Thanks.

@Arjupta
Copy link
Contributor

Arjupta commented Sep 30, 2020

@Arjupta Thanks for going through the previous PR. I suggest trying out your own approach while keeping that previous PR in mind.

@aggarwalpulkit596 Thanks for helping out.

Okay Sir, I will use the previous PR as a guide only, probably with a new approach.

Also, I will look into other issues also while working on this. Thanks :)

@BenHenning BenHenning added the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 1, 2020
@MohamedMedhat1998 MohamedMedhat1998 mentioned this issue Oct 11, 2020
Closed
@Arjupta Arjupta removed their assignment Oct 16, 2020
@Arjupta
Copy link
Contributor

Arjupta commented Oct 16, 2020

I won't be able to work on it currently so unassigning myself for now

@prakharp
Copy link

prakharp commented Nov 4, 2020

Hey, Can I work on this issue?

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 5, 2020

Hey, Can I work on this issue?

Sure. Assigning this to you.

@rt4914
Copy link
Contributor Author

rt4914 commented Aug 11, 2021

@UttaranDas I am un-assigning you this issue. Also can you work on #3504 so that we can solve it as well as unblock this PR.

@rt4914 rt4914 changed the title Status bar color fix for pre-lollipop versions Status bar color fix for pre-lollipop versions [Blocked on #3504] Aug 11, 2021
@rt4914
Copy link
Contributor Author

rt4914 commented Aug 18, 2021

@UttaranDas I am un-assigning you this issue. Also can you work on #3504 so that we can solve it as well as unblock this PR.

@UttaranDas Any updates on this?

@rt4914 rt4914 changed the title Status bar color fix for pre-lollipop versions [Blocked on #3504] Status bar color fix for pre-lollipop versions Jan 19, 2022
@Broppia Broppia added issue_type_bug Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Jul 29, 2022
@BenHenning BenHenning added Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. TODO: need task force Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta milestone Sep 16, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_user_learner labels Mar 29, 2023
@seanlip
Copy link
Member

seanlip commented Jun 4, 2023

Per #5012, we are deprecating support for Android KitKat, so this issue is no longer valid.

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1042 Status bar color for pre-lollipop versions prathameshbhalekar/oppia-android