Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
<!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation Fixes #5283, changed wrap_content to fixed width for cardview width. <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> After Fix, accessibility check not suggesting text scaling( Referencing issue #4736) ![WhatsApp Image 2023-12-23 at 5 43 08 PM](https://github.com/oppia/oppia-android/assets/76042077/acd91e4d-43fa-4589-b353-7e8d167e4cf0) ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [ ] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [ ] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [ ] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [ ] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [ ] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [ ] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only | Before| After| |--------|--------| |![concept_card_overlaping](https://github.com/oppia/oppia-android/assets/76042077/b76e6a0d-ac11-420c-8c67-2580c27b316c)| ![overlapfix](https://github.com/oppia/oppia-android/assets/76042077/37e24271-8008-4618-97d4-889bc4ff9512) | |![cardoverlapbeforetablet](https://github.com/oppia/oppia-android/assets/76042077/c8f8ee4b-26e0-477d-b241-620146bab551)| ![tabletcardoverlap](https://github.com/oppia/oppia-android/assets/76042077/74cdb540-d050-489e-b19f-e8c586780afe) | <!-- Delete these section if this PR does not include UI-related changes. --> If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing