Skip to content

Commit

Permalink
Fix #4255: Double number of shards available for app tests (#4313)
Browse files Browse the repository at this point in the history
* Double number of shards available for app tests

App module tests are still running into memory issues (specifically shards 2 & 3). This change doubles the number of shards available so that hopefully the tests are better distributes and have a smaller chance of hitting memory limitations.

* Update main.yml

Ensure new shards are run in CI.
  • Loading branch information
BenHenning authored Apr 26, 2022
1 parent 05b1816 commit caced66
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ jobs:
strategy:
fail-fast: false
matrix:
shard: [shard0, shard1, shard2, shard3]
shard: [shard0, shard1, shard2, shard3, shard4, shard5, shard6, shard7]
steps:
- uses: actions/checkout@v2

Expand Down
2 changes: 1 addition & 1 deletion app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ _excludeTestFiles(filesToExclude)
// one shard after another without cleaning first (since Gradle doesn't handle file exclusion well,
// it expects files to be present corresponding to generated code, such as Dagger, from previous
// runs).
def appModuleShardCount = 4
def appModuleShardCount = 8
def shardIndexes = 0..(appModuleShardCount - 1)
shardIndexes.each { shardIndex ->
if (project.gradle.startParameter?.taskRequests?.args[0]?.remove("--shard$shardIndex".toString())) {
Expand Down

0 comments on commit caced66

Please sign in to comment.