Fix #3240: Hi fi app versoin shadow fix (#3806)

* removed view and fragment layout from app_version_fragment * added view in app_version_activity.xml * final change * made suggested changes * made suggested changes
oppia · Sep 24, 2021 · baf7fd2 · baf7fd2
1 parent 87125aa
commit baf7fd2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/app/src/main/res/layout/app_version_activity.xml b/app/src/main/res/layout/app_version_activity.xml
@@ -29,6 +29,16 @@
       app:titleTextColor="@color/white" />
   </com.google.android.material.appbar.AppBarLayout>
 
+  <View
+    android:id="@+id/app_version_shadow_view"
+    android:layout_width="0dp"
+    android:layout_height="4dp"
+    android:layout_gravity="top"
+    android:background="@drawable/toolbar_drop_shadow"
+    app:layout_constraintStart_toStartOf="parent"
+    app:layout_constraintEnd_toEndOf="parent"
+    app:layout_constraintTop_toBottomOf="@id/app_version_app_bar_layout" />
+
   <FrameLayout
     android:id="@+id/app_version_fragment_placeholder"
     android:layout_width="match_parent"

diff --git a/app/src/main/res/layout/app_version_fragment.xml b/app/src/main/res/layout/app_version_fragment.xml
@@ -9,10 +9,6 @@
       type="org.oppia.android.app.administratorcontrols.appversion.AppVersionViewModel" />
   </data>
 
-  <FrameLayout
-    android:layout_width="match_parent"
-    android:layout_height="match_parent">
-
     <androidx.constraintlayout.widget.ConstraintLayout
       android:layout_width="match_parent"
       android:layout_height="match_parent"
@@ -61,12 +57,4 @@
         app:layout_constraintStart_toEndOf="@id/app_info_image_view"
         app:layout_constraintTop_toBottomOf="@id/app_version_text_view" />
     </androidx.constraintlayout.widget.ConstraintLayout>
-
-    <View
-      android:id="@+id/app_version_shadow_view"
-      android:layout_width="match_parent"
-      android:layout_height="4dp"
-      android:layout_gravity="top"
-      android:background="@drawable/toolbar_drop_shadow" />
-  </FrameLayout>
 </layout>