Skip to content

Commit

Permalink
Update build artifact workflows & repository messaging (#4797)
Browse files Browse the repository at this point in the history
## Explanation
This PR does two things:
- It updates repository messaging to indicate multiple team members may
be unavailable until early January (which will show on all new/reopened
PRs once this is merged). I'll update existing PRs so that authors are
aware.
- It updates the build tests CI workflow to only upload the Oppia dev
APK (as this is the only one practically useful for developers since the
AABs can't be directly installed on a device).

## Essential Checklist
- [ ] ~The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)~
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
N/A -- Infrastructure-only change.
  • Loading branch information
BenHenning authored Dec 21, 2022
1 parent 1a0b7ef commit b7f0588
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 62 deletions.
60 changes: 0 additions & 60 deletions .github/workflows/build_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,18 +148,12 @@ jobs:
- name: Copy Oppia dev APKs for uploading
run: |
cp $GITHUB_WORKSPACE/bazel-bin/oppia.apk /home/runner/work/oppia-android/oppia-android/
cp $GITHUB_WORKSPACE/bazel-bin/oppia_kitkat.apk /home/runner/work/oppia-android/oppia-android/
- uses: actions/upload-artifact@v2
with:
name: oppia-bazel.apk
path: /home/runner/work/oppia-android/oppia-android/oppia.apk

- uses: actions/upload-artifact@v2
with:
name: oppia-bazel-kitkat.apk
path: /home/runner/work/oppia-android/oppia-android/oppia_kitkat.apk

build_oppia_dev_aab:
name: Build Oppia AAB (developer flavors)
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -294,21 +288,6 @@ jobs:
run: |
bazel build -- //:oppia_dev_kitkat
- name: Copy Oppia developer AABs for uploading
run: |
cp $GITHUB_WORKSPACE/bazel-bin/oppia_dev.aab /home/runner/work/oppia-android/oppia-android/
cp $GITHUB_WORKSPACE/bazel-bin/oppia_dev_kitkat.aab /home/runner/work/oppia-android/oppia-android/
- uses: actions/upload-artifact@v2
with:
name: oppia_dev.aab
path: /home/runner/work/oppia-android/oppia-android/oppia_dev.aab

- uses: actions/upload-artifact@v2
with:
name: oppia_dev_kitkat.aab
path: /home/runner/work/oppia-android/oppia-android/oppia_dev_kitkat.aab

build_oppia_alpha_aab:
name: Build Oppia AAB (alpha flavors)
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -456,27 +435,6 @@ jobs:
run: |
bazel build --compilation_mode=opt -- //:oppia_alpha_kenya
- name: Copy Oppia alpha AABs for uploading
run: |
cp $GITHUB_WORKSPACE/bazel-bin/oppia_alpha.aab /home/runner/work/oppia-android/oppia-android/
cp $GITHUB_WORKSPACE/bazel-bin/oppia_alpha_kitkat.aab /home/runner/work/oppia-android/oppia-android/
cp $GITHUB_WORKSPACE/bazel-bin/oppia_alpha_kenya.aab /home/runner/work/oppia-android/oppia-android/
- uses: actions/upload-artifact@v2
with:
name: oppia_alpha.aab
path: /home/runner/work/oppia-android/oppia-android/oppia_alpha.aab

- uses: actions/upload-artifact@v2
with:
name: oppia_alpha_kitkat.aab
path: /home/runner/work/oppia-android/oppia-android/oppia_alpha_kitkat.aab

- uses: actions/upload-artifact@v2
with:
name: oppia_alpha_kenya.aab
path: /home/runner/work/oppia-android/oppia-android/oppia_alpha_kenya.aab

build_oppia_beta_aab:
name: Build Oppia AAB (beta flavor)
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -598,15 +556,6 @@ jobs:
run: |
bazel build --compilation_mode=opt -- //:oppia_beta
- name: Copy Oppia beta AAB for uploading
run: |
cp $GITHUB_WORKSPACE/bazel-bin/oppia_beta.aab /home/runner/work/oppia-android/oppia-android/
- uses: actions/upload-artifact@v2
with:
name: oppia_beta.aab
path: /home/runner/work/oppia-android/oppia-android/oppia_beta.aab

build_oppia_ga_aab:
name: Build Oppia AAB (GA flavor)
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -727,12 +676,3 @@ jobs:
if: ${{ env.ENABLE_CACHING == 'false' || github.event.pull_request.head.repo.full_name != 'oppia/oppia-android' }}
run: |
bazel build --compilation_mode=opt -- //:oppia_ga
- name: Copy Oppia GA AAB for uploading
run: |
cp $GITHUB_WORKSPACE/bazel-bin/oppia_ga.aab /home/runner/work/oppia-android/oppia-android/
- uses: actions/upload-artifact@v2
with:
name: oppia_ga.aab
path: /home/runner/work/oppia-android/oppia-android/oppia_ga.aab
4 changes: 2 additions & 2 deletions .github/workflows/repository_messaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
holiday_message:
runs-on: ubuntu-latest
# NOTE TO DEVELOPERS: Update the body text and set this to 'true' to enable automatic messaging on all new PRs.
if: false
if: true
steps:
- name: Add holiday comment
uses: peter-evans/create-or-update-comment@v1
Expand All @@ -21,4 +21,4 @@ jobs:
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 23 May 2022.
returning on 10 January 2022.

0 comments on commit b7f0588

Please sign in to comment.