Skip to content

Commit

Permalink
Running the coverage script only once remvoing attempts
Browse files Browse the repository at this point in the history
  • Loading branch information
Rd4dev committed Jul 19, 2024
1 parent 7c32b5e commit b3df84b
Showing 1 changed file with 19 additions and 19 deletions.
38 changes: 19 additions & 19 deletions .github/workflows/code_coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -279,16 +279,16 @@ jobs:
BAZEL_REMOTE_CACHE_URL: ${{ secrets.BAZEL_REMOTE_CACHE_URL }}
CHANGED_FILES: ${{ env.CHANGED_FILES }}
run: |
# Attempt to build 5 times in case there are flaky builds.
# TODO(#3970): Remove this once there are no longer app test build failures.
i=0
# Disable exit-on-first-failure.
set +e
while [ $i -ne 5 ]; do
i=$(( $i+1 ))
echo "Attempt $i/5 to run test targets"
bazel run //scripts:run_coverage -- $(pwd) $CHANGED_FILES --format=MARKDOWN
done
# # Attempt to build 5 times in case there are flaky builds.
# # TODO(#3970): Remove this once there are no longer app test build failures.
# i=0
# # Disable exit-on-first-failure.
# set +e
# while [ $i -ne 5 ]; do
# i=$(( $i+1 ))
# echo "Attempt $i/5 to run test targets"
bazel run //scripts:run_coverage -- $(pwd) $CHANGED_FILES --format=MARKDOWN
# done
# Capture the error code of the final command run (which should be a success if there isn't a real build failure).
last_error_code=$?
# Reenable exit-on-first-failure.
Expand All @@ -301,15 +301,15 @@ jobs:
env:
BAZEL_TEST_TARGETS: ${{ env.BAZEL_TEST_TARGETS }}
run: |
# Attempt to build 5 times in case there are flaky builds.
# TODO(#3970): Remove this once there are no longer app test build failures.
i=0
# Disable exit-on-first-failure.
set +e
while [ $i -ne 5 ]; do
i=$(( $i+1 ))
echo "Attempt $i/5 to run test targets"
bazel run //scripts:run_coverage -- $(pwd) $CHANGED_FILES --format=MARKDOWN
# # Attempt to build 5 times in case there are flaky builds.
# # TODO(#3970): Remove this once there are no longer app test build failures.
# i=0
# # Disable exit-on-first-failure.
# set +e
# while [ $i -ne 5 ]; do
# i=$(( $i+1 ))
# echo "Attempt $i/5 to run test targets"
bazel run //scripts:run_coverage -- $(pwd) $CHANGED_FILES --format=MARKDOWN
done
# Capture the error code of the final command run (which should be a success if there isn't a real build failure).
last_error_code=$?
Expand Down

0 comments on commit b3df84b

Please sign in to comment.