Skip to content

Commit

Permalink
Fixed #4888 : Remove the unused condition from lessons_completed_chap…
Browse files Browse the repository at this point in the history
…ter_view.xml for Accessibility (#4889)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

Fixed #4888 : Remove the unused condition from
lessons_completed_chapter_view.xml for Accessibility


<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing

Co-authored-by: Rajat Talesra <[email protected]>
  • Loading branch information
MohitGupta121 and rt4914 authored Mar 11, 2023
1 parent 1addc8f commit 90347ac
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions app/src/main/res/layout/lessons_completed_chapter_view.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
android:background="@color/component_color_lessons_tab_activity_lessons_completed_chapter_index_background_color"
android:fontFamily="sans-serif"
android:gravity="center"
android:importantForAccessibility="@{viewModel.chapterPlayState != ChapterPlayState.NOT_PLAYABLE_MISSING_PREREQUISITES ? View.IMPORTANT_FOR_ACCESSIBILITY_YES : View.IMPORTANT_FOR_ACCESSIBILITY_NO}"
android:importantForAccessibility="yes"
android:minWidth="60dp"
android:minHeight="48dp"
android:paddingStart="8dp"
Expand All @@ -48,12 +48,12 @@
android:background="@color/component_color_lessons_tab_activity_lessons_completed_chapter_name_background_color"
android:fontFamily="sans-serif"
android:gravity="center|start"
android:importantForAccessibility="@{viewModel.chapterPlayState != ChapterPlayState.NOT_PLAYABLE_MISSING_PREREQUISITES ? View.IMPORTANT_FOR_ACCESSIBILITY_YES : View.IMPORTANT_FOR_ACCESSIBILITY_NO}"
android:importantForAccessibility="yes"
android:minHeight="48dp"
android:paddingStart="12dp"
android:paddingEnd="12dp"
android:text="@{viewModel.chapterTitle}"
android:textColor="@{viewModel.chapterPlayState != ChapterPlayState.NOT_PLAYABLE_MISSING_PREREQUISITES ? @color/component_color_shared_primary_text_color : @color/component_color_shared_primary_text_color}"
android:textColor="@color/component_color_shared_primary_text_color"
android:textSize="14sp"
app:layout_constraintBottom_toTopOf="@id/divider"
app:layout_constraintEnd_toEndOf="parent"
Expand Down

0 comments on commit 90347ac

Please sign in to comment.