Skip to content

Commit

Permalink
Fix #4649: Updates audio option name (#5165)
Browse files Browse the repository at this point in the history
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

Fixes #4649

This PR changes the `audio_language` & `audio_language_activity_title`
string in `strings.xml` file to `Preferred Audio Language`.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing

<img
src="https://github.com/oppia/oppia-android/assets/84731134/ee45c13d-5181-4cc8-991c-73a204884eae"
width="300"/>
<img
src="https://github.com/oppia/oppia-android/assets/84731134/b4cc6942-43fa-45f5-8dd0-081eeae7b064"
width="300"/>
  • Loading branch information
theMr17 authored Oct 1, 2023
1 parent 9bbf94a commit 716d3a0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -413,12 +413,12 @@
<string name="app_version_activity_title">App Version</string>
<!-- OptionsActivity -->
<string name="app_language_activity_title">App Language</string>
<string name="audio_language_activity_title">Default Audio Language</string>
<string name="audio_language_activity_title">Preferred Audio Language</string>
<string name="reading_text_size_activity_title">Reading Text Size</string>
<string name="title_reading_text_size">Reading Text Size</string>
<string name="story_text_will_look_like_this">Story text will look like this.</string>
<string name="constant_string_for_text_size">A</string>
<string name="audio_language">Default Audio</string>
<string name="audio_language">Preferred Audio Language</string>
<string name="app_language">App Language</string>
<string name="reading_text_size">Reading Text Size</string>
<string name="reading_text_size_small">Small</string>
Expand Down

0 comments on commit 716d3a0

Please sign in to comment.