Skip to content

Commit

Permalink
Fix #3566: Merge profile_rename_activity.xml into single xml file (#3950
Browse files Browse the repository at this point in the history
)

* solution summary xml merged

* Revert "solution summary xml merged"

This reverts commit d3638f1.

* conflict resolved and files changes solution_summary

* merge profile reset pin activity

* merge profile rename activity
  • Loading branch information
MohitGupta121 authored Nov 9, 2021
1 parent b86cfa1 commit 65f04b7
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 110 deletions.
105 changes: 0 additions & 105 deletions app/src/main/res/layout-land/profile_rename_activity.xml

This file was deleted.

10 changes: 5 additions & 5 deletions app/src/main/res/layout/profile_rename_activity.xml
Original file line number Diff line number Diff line change
Expand Up @@ -50,17 +50,17 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:background="@drawable/general_item_background_border"
android:paddingBottom="32dp"
android:paddingBottom="@dimen/profile_rename_activity_constraint_layout"
app:layout_constraintTop_toTopOf="parent">

<com.google.android.material.textfield.TextInputLayout
android:id="@+id/profile_rename_input"
style="@style/TextInputLayout"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginStart="28dp"
android:layout_marginTop="28dp"
android:layout_marginEnd="28dp"
android:layout_marginStart="@dimen/profile_rename_activity_profile_rename_input_margin_start"
android:layout_marginTop="@dimen/profile_rename_activity_profile_rename_input_margin_top"
android:layout_marginEnd="@dimen/profile_rename_activity_profile_rename_input_margin_end"
android:hint="@string/profile_rename_label"
app:errorMessage="@{viewModel.nameErrorMsg}"
app:layout_constraintEnd_toEndOf="parent"
Expand All @@ -84,7 +84,7 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="16dp"
android:layout_marginEnd="28dp"
android:layout_marginEnd="@dimen/profile_rename_activity_profile_rename_save_button_margin_end"
android:background="@{viewModel.inputName.length > 0 ? @drawable/state_button_primary_background :@drawable/start_button_transparent_background}"
android:clickable="@{viewModel.inputName.length > 0}"
android:enabled="@{viewModel.inputName.length > 0}"
Expand Down
7 changes: 7 additions & 0 deletions app/src/main/res/values-land/dimens.xml
Original file line number Diff line number Diff line change
Expand Up @@ -377,4 +377,11 @@
<dimen name="profile_reset_pin_activity_profile_reset_input_confirm_pin_margin_end">168dp</dimen>
<dimen name="profile_reset_pin_activity_profile_reset_save_button_margin_end">168dp</dimen>

<!-- Profile Rename Activity -->
<dimen name="profile_rename_activity_constraint_layout">56dp</dimen>
<dimen name="profile_rename_activity_profile_rename_input_margin_start">168dp</dimen>
<dimen name="profile_rename_activity_profile_rename_input_margin_top">32dp</dimen>
<dimen name="profile_rename_activity_profile_rename_input_margin_end">168dp</dimen>
<dimen name="profile_rename_activity_profile_rename_save_button_margin_end">168dp</dimen>

</resources>
7 changes: 7 additions & 0 deletions app/src/main/res/values/dimens.xml
Original file line number Diff line number Diff line change
Expand Up @@ -577,4 +577,11 @@
<dimen name="profile_reset_pin_activity_profile_reset_input_confirm_pin_margin_end">28dp</dimen>
<dimen name="profile_reset_pin_activity_profile_reset_save_button_margin_end">28dp</dimen>

<!-- Profile Rename Activity -->
<dimen name="profile_rename_activity_constraint_layout">32dp</dimen>
<dimen name="profile_rename_activity_profile_rename_input_margin_start">28dp</dimen>
<dimen name="profile_rename_activity_profile_rename_input_margin_top">28dp</dimen>
<dimen name="profile_rename_activity_profile_rename_input_margin_end">28dp</dimen>
<dimen name="profile_rename_activity_profile_rename_save_button_margin_end">28dp</dimen>

</resources>

0 comments on commit 65f04b7

Please sign in to comment.