Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
<!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> Fix #3844: When merged, this PR will; - Remove the `R.plurals.chapter_count_with_story_name` from the strings file. - Remove all translations of the `R.plurals.chapter_count_with_story_name`. - Delete the `computeStoryNameChapterCountContainerContentDescription()` method from `StorySummaryViewModel` which is no longer used. The approach to delete the above files was necessitated by a change made on [PR #4441](#4441). The PR switched from a chapter-based progress system i.e. _Chapter 1 of 10_ to a percentage-based progress system. This made the `chapter_count_with_story_name` strings and the `computeStoryNameChapterCountContainerContentDescription()` method used to generate the chapter-based progress text redundant. These have been removed to eliminate this redundancy. ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). --------- Co-authored-by: Ben Henning <[email protected]>
- Loading branch information