requested changes

oppia · Oct 11, 2024 · 45dd3a0 · 45dd3a0
1 parent 71fc4e9
commit 45dd3a0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/utility/src/main/java/org/oppia/android/util/logging/ConsoleLogger.kt b/utility/src/main/java/org/oppia/android/util/logging/ConsoleLogger.kt
@@ -35,7 +35,6 @@ class ConsoleLogger @Inject constructor(
    */
   val logErrorMessagesFlow: SharedFlow<ConsoleLoggerContext> = _logErrorMessagesFlow
 
-  /** Long-lived PrintWriter to improve performance by not reopening the file every time */
   private var printWriter: PrintWriter? = null
 
   /** Logs a verbose message with the specified tag. */
@@ -136,15 +135,15 @@ class ConsoleLogger @Inject constructor(
   private fun logToFileInBackground(text: String) {
     blockingScope.launch {
       if (printWriter == null) {
-        printWriter = PrintWriter(FileWriter(logDirectory, true)) // Open in append mode
+        printWriter = PrintWriter(FileWriter(logDirectory, true)) // Open in append mode.
       }
       printWriter?.println(text)
       printWriter?.flush()
     }
   }
 
   /** Close the log file when logging is finished. */
-  fun closeLogFile() {
+  private fun closeLogFile() {
     printWriter?.close()
     printWriter = null
   }

diff --git a/utility/src/test/java/org/oppia/android/util/logging/ConsoleLoggerTest.kt b/utility/src/test/java/org/oppia/android/util/logging/ConsoleLoggerTest.kt
@@ -61,7 +61,7 @@ class ConsoleLoggerTest {
   fun setUp() {
     setUpTestApplicationComponent()
     logFile = File(context.filesDir, "oppia_app.log")
-    logFile.delete() // Ensure we start with a clean log file
+    logFile.delete() // Ensure we start with a clean log file.
   }
 
   @Test