Skip to content

Commit

Permalink
Fixes #4539: Replace CaseSensitiveEquals by Equals in dev assets (#5154)
Browse files Browse the repository at this point in the history
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
Fixes #4539: Replace the rule type CaseSensitiveEquals by Equals in dev
assets. This only affects the topics used in dev environment. The rule
type CaseSensitiveEquals is no longer supported.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing


**Videos**

|current|new|
|-|-|

|[fix_for_CaseSensitiveEquals_current.webm](https://github.com/oppia/oppia-android/assets/103062089/0ad9f1e9-a991-4908-8576-1aba964fadcb)|[fix_for_CaseSensitiveEquals_new.webm](https://github.com/oppia/oppia-android/assets/103062089/298270d9-6af2-4cb8-a9f0-6445e5abfdd6)|

**Screenshots**

|current|new|
|-|-|
|![Screenshot
fix_for_CaseSensitiveEquals_current](https://github.com/oppia/oppia-android/assets/103062089/b135fce1-270e-46d9-b819-82833011988d)|![Screenshot
fix_for_CaseSensitiveEquals_new](https://github.com/oppia/oppia-android/assets/103062089/443f966f-717b-4fab-b17a-11d52e817737)|

---------

Co-authored-by: Adhiambo Peres <[email protected]>
  • Loading branch information
masclot and adhiamboperes authored Sep 28, 2023
1 parent 0898127 commit 42ee1bd
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions domain/src/main/assets/2mzzFVDLuAj8.json
Original file line number Diff line number Diff line change
Expand Up @@ -2463,7 +2463,7 @@
}
}
}, {
"rule_type": "CaseSensitiveEquals",
"rule_type": "Equals",
"inputs": {
"x": {
"contentId": "14186351-eee4-40fa-8f20-960306cfe465",
Expand Down Expand Up @@ -2818,15 +2818,15 @@
}
}
}, {
"rule_type": "CaseSensitiveEquals",
"rule_type": "Equals",
"inputs": {
"x": {
"contentId": "c78bf24e-b510-4bac-a107-28a03dfa1c22",
"normalizedStrSet": ["3 to1"]
}
}
}, {
"rule_type": "CaseSensitiveEquals",
"rule_type": "Equals",
"inputs": {
"x": {
"contentId": "338cb82a-5e6f-460a-8fa0-5a2510c1a31e",
Expand Down
6 changes: 3 additions & 3 deletions domain/src/main/assets/2mzzFVDLuAj8.textproto
Original file line number Diff line number Diff line change
Expand Up @@ -3011,7 +3011,7 @@ states {
}
}
}
rule_type: "CaseSensitiveEquals"
rule_type: "Equals"
}
}
answer_groups {
Expand Down Expand Up @@ -3472,7 +3472,7 @@ states {
}
}
}
rule_type: "CaseSensitiveEquals"
rule_type: "Equals"
}
rule_specs {
input {
Expand All @@ -3484,7 +3484,7 @@ states {
}
}
}
rule_type: "CaseSensitiveEquals"
rule_type: "Equals"
}
}
answer_groups {
Expand Down
4 changes: 2 additions & 2 deletions domain/src/main/assets/5NWuolNcwH6e.json
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@
}
}
}, {
"rule_type": "CaseSensitiveEquals",
"rule_type": "Equals",
"inputs": {
"x": {
"contentId": "947c6855-b9e6-459d-a8f6-2b239e51d37f",
Expand Down Expand Up @@ -2176,7 +2176,7 @@
}
}
}, {
"rule_type": "CaseSensitiveEquals",
"rule_type": "Equals",
"inputs": {
"x": {
"contentId": "5d0d1769-2754-4f6a-9690-ba3675ce953d",
Expand Down
4 changes: 2 additions & 2 deletions domain/src/main/assets/5NWuolNcwH6e.textproto
Original file line number Diff line number Diff line change
Expand Up @@ -1121,7 +1121,7 @@ states {
}
}
}
rule_type: "CaseSensitiveEquals"
rule_type: "Equals"
}
}
default_outcome {
Expand Down Expand Up @@ -2807,7 +2807,7 @@ states {
}
}
}
rule_type: "CaseSensitiveEquals"
rule_type: "Equals"
}
rule_specs {
input {
Expand Down

0 comments on commit 42ee1bd

Please sign in to comment.