Skip to content

Commit

Permalink
Adding the missed out !cancelled conditional check and removed the re…
Browse files Browse the repository at this point in the history
…dundant failure check for the PASS statement
  • Loading branch information
Rd4dev committed Sep 5, 2024
1 parent bfe4a99 commit 3294c20
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions .github/workflows/static_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -208,14 +208,13 @@ jobs:
bazel run //scripts:string_resource_validation_check -- $(pwd)
- name: Binary files check
# The expression if: ${{ !cancelled() }} runs a job or step regardless of its success or failure while responding to cancellations,
# serving as a cancellation-compliant alternative to if: ${{ always() }} in concurrent workflows.
if: ${{ !cancelled() }}
run: |
bash /home/runner/work/oppia-android/oppia-android/scripts/pre-commit.sh
exit_code=$?
if [ $exit_code -eq 0 ]; then
echo "No binary files found"
echo "BINARY FILES CHECK PASSED"
fi
echo "No binary files found"
echo "BINARY FILES CHECK PASSED"
# Note that caching is intentionally not enabled for this check since licenses should always be
# verified without any potential influence from earlier builds (i.e. always from a clean build to
Expand Down

0 comments on commit 3294c20

Please sign in to comment.