Fixed Part #4200 : Added dark mode support to AudioLanguageActivity, …

…ReadingTextSizeActivity, AppLanguageActivity (#4415) * fixed text cut off * fix text cutoff in all layouts * add proper naming * implement darkmode AudioLanguage,ReadingTextSize,AppLanguage Activities * minor fixes * develop updated * minor changes * fixed build error * Tests Failed Fixed * Update color_defs.xml * added EOL
oppia · Aug 24, 2022 · 2ff2945 · 2ff2945
1 parent ca39ac6
commit 2ff2945
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 6 deletions.
diff --git a/app/src/main/res/drawable/general_item_background_border_light.xml b/app/src/main/res/drawable/general_item_background_border_light.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <shape xmlns:android="http://schemas.android.com/apk/res/android"
   android:shape="rectangle">
-  <solid android:color="@color/color_def_white" />
+  <solid android:color="@color/component_color_language_items_background_color" />
   <stroke
     android:width="1dp"
     android:color="@color/oppia_text_shadow" />

diff --git a/app/src/main/res/layout/app_language_fragment.xml b/app/src/main/res/layout/app_language_fragment.xml
@@ -25,7 +25,7 @@
         android:id="@+id/language_recycler_view"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
-        android:background="@color/general_navigation_background"
+        android:background="@color/component_color_app_language_activity_background_color"
         android:clipToPadding="false"
         android:overScrollMode="never"
         android:paddingBottom="@dimen/app_language_recycler_view_padding_bottom"

diff --git a/app/src/main/res/layout/audio_language_fragment.xml b/app/src/main/res/layout/audio_language_fragment.xml
@@ -25,7 +25,7 @@
         android:id="@+id/audio_language_recycler_view"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
-        android:background="@color/general_navigation_background"
+        android:background="@color/component_color_audio_language_activity_background_color"
         android:clipToPadding="false"
         android:overScrollMode="never"
         android:paddingBottom="@dimen/audio_language_recycler_view_padding_bottom"

diff --git a/app/src/main/res/layout/language_items.xml b/app/src/main/res/layout/language_items.xml
@@ -39,7 +39,7 @@
       android:layout_marginEnd="24dp"
       android:fontFamily="sans-serif"
       android:text="@{viewModel.language}"
-      android:textColor="@color/oppia_primary_text"
+      android:textColor="@color/component_color_language_items_heading_text_color"
       android:textSize="16sp" />
   </LinearLayout>
 </layout>
diff --git a/app/src/main/res/layout/reading_text_size_fragment.xml b/app/src/main/res/layout/reading_text_size_fragment.xml
@@ -13,7 +13,7 @@
     android:id="@+id/text_size_recycler_view"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
-    android:background="@color/general_navigation_background"
+    android:background="@color/component_color_reading_text_size_activity_background_color"
     android:clipToPadding="false"
     android:overScrollMode="never"
     android:paddingBottom="@dimen/reading_text_size_fragment_padding_bottom"

diff --git a/app/src/main/res/layout/text_size_items.xml b/app/src/main/res/layout/text_size_items.xml
@@ -40,7 +40,7 @@
       android:layout_marginEnd="24dp"
       android:fontFamily="sans-serif"
       android:text="@{viewModel.textSizeName}"
-      android:textColor="@color/oppia_primary_text"
+      android:textColor="@color/component_color_reading_text_size_items_heading_text_color"
       android:textSize="@{viewModel.textSize}" />
   </LinearLayout>
 </layout>
diff --git a/app/src/main/res/values/component_colors.xml b/app/src/main/res/values/component_colors.xml
@@ -205,4 +205,13 @@
   <color name="component_color_mark_topics_completed_background_color">@color/color_palette_mark_chapters_background_color</color>
   <color name="component_color_mark_topics_completed_text_mark_completed_color">@color/color_palette_mark_completed_text_color</color>
   <color name="component_color_mark_topics_completed_text_all_color">@color/color_palette_mark_completed_all_text_color</color>
+  <!-- Audio Language Activity -->
+  <color name="component_color_audio_language_activity_background_color">@color/color_palette_dark_background_color</color>
+  <color name="component_color_language_items_background_color">@color/color_palette_container_background_color</color>
+  <color name="component_color_language_items_heading_text_color">@color/color_palette_dark_text_color</color>
+  <!-- Reading Text Size Activity -->
+  <color name="component_color_reading_text_size_activity_background_color">@color/color_palette_dark_background_color</color>
+  <color name="component_color_reading_text_size_items_heading_text_color">@color/color_palette_dark_text_color</color>
+  <!-- App Language Activity -->
+  <color name="component_color_app_language_activity_background_color">@color/color_palette_dark_background_color</color>
 </resources>