Skip to content

Commit

Permalink
Add codeowners to translation strings files. (#4992)
Browse files Browse the repository at this point in the history
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
Adding @adhiamboperes and me to codeowners so that we can help with
translation string file approvals (like #4969).

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [ ] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

Co-authored-by: Ben Henning <[email protected]>
  • Loading branch information
seanlip and BenHenning authored May 27, 2023
1 parent 5c32f7b commit 086f0d4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ gradlew.bat @BenHenning
/utility/src/main/res/**/*.xml @BenHenning

# App UI strings.
/app/src/main/res/values*/strings.xml @BenHenning
/app/src/main/res/values*/strings.xml @BenHenning @seanlip @adhiamboperes
/app/src/main/res/values*/untranslated_strings.xml @BenHenning

# Proguard configurations.
Expand Down

0 comments on commit 086f0d4

Please sign in to comment.