Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move adagios/media/externals into a sub-module #458

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

palli
Copy link
Contributor

@palli palli commented Nov 9, 2014

This patch removes all third party javascript dependencies from adagios.

I created a new repository github.com/opinkerfi/adagios-dependencies and added adagios/media/externals as a sub-module.

This makes the adagios repository cleaner, and can facilitate for more manageable bower integration in the future.

Please review and give feedback.

Pall Sigurdsson added 2 commits November 9, 2014 13:53
Moving this into sub-module github.com/opinkerfi/adagios-dependencies
@palli palli mentioned this pull request Nov 9, 2014
@palli
Copy link
Contributor Author

palli commented Nov 9, 2014

Caveats with this patch:

Existing developers need to run the following:
git submodule init
git submodule update

Or simpler, when cloning a new adagios repo from github use:
git clone http://github.com/opinkerfi/adagios --recursive

@palli
Copy link
Contributor Author

palli commented Nov 21, 2014

Any comments, from @pall-valmundsson or @tomas-edwardsson ?

@titilambert
Copy link
Contributor

@palli I think we have to remove the .git file from the submodule root folder in debian packaging

@tomas-edwardsson
Copy link
Contributor

@titilambert can you confirm that the deb packaging change is needed? I'm quite sure that rpm packaging also needs to be updated although I don't see anything needing to be changed in the adagios source.

Other than that I think we should merge and try this out. I see a definite benefit for developers not working on the javascript side to be free from thinking about javascript dependencies like npm and bower.

If this becomes akward to work with later down the road we can always change how we do this.

I've done some rudamentary tests and I see no change in functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants