Bug/60538 misplaced cursor in comments text editor on ios #17880
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akabiru
force-pushed
the
bug/60538-misplaced-cursor-in-comments-text-editor-on-ios
branch
from
ac2aba5 to
c3e27b4
Compare
An attempt to avoid cursor misplacement on iOS resulting from content overlay
[*with AI Help] There appears to be a race condition between: 1. The iOS virtual keyboard 2. CKEditor's content area height adjustment 3. The scroll positioning logic To address this, focus the editor then wait for virtual keyboard (takes ~300-400ms acc to Apple) before scrolling the editor into view. > on iOS, the virtual keyboard animation takes ~300-400ms to complete, and during this time it's adjusting the viewport. This explains why you sometimes need to tap twice - the first focus attempt may be interrupted by the viewport changes.
akabiru
force-pushed
the
bug/60538-misplaced-cursor-in-comments-text-editor-on-ios
branch
from
c3e27b4 to
6176547
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/60538
What are you trying to accomplish?
Screenshots
What approach did you choose and why?
Merge checklist